Skip to content

fix(info): the slave lag in INFO command might be overflowed #3271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PragmaTwice merged 3 commits into from
Nov 27, 2025
Merged

fix(info): the slave lag in INFO command might be overflowed #3271

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0efa83f
fix the uint64_t lag overflowed when master_repl_offset is smaller th…
greatsharp Nov 25, 2025
2dcb801
set lag value to 0 when master_repl_offset is smaller than slave ack …
greatsharp Nov 26, 2025
583cb38
get latest_seq after lock
greatsharp Nov 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions src/server/server.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1215,24 +1215,25 @@ Server::InfoEntries Server::GetReplicationInfo() {
}

int idx = 0;
rocksdb::SequenceNumber latest_seq = storage->LatestSeqNumber();

{
std::shared_lock<std::shared_mutex> guard(slave_threads_mu_);
entries.emplace_back("connected_slaves", slave_threads_.size());
rocksdb::SequenceNumber latest_seq = storage->LatestSeqNumber();
for (const auto &slave : slave_threads_) {
if (slave->IsStopped()) continue;

auto slave_ack_seq = slave->GetAckSeq();
entries.emplace_back(
Comment thread
greatsharp marked this conversation as resolved.
"slave" + std::to_string(idx),
fmt::format("ip={},port={},offset={},lag={}", slave->GetConn()->GetAnnounceIP(),
slave->GetConn()->GetAnnouncePort(), slave->GetAckSeq(), latest_seq - slave->GetAckSeq()));
slave->GetConn()->GetAnnouncePort(), slave_ack_seq >= latest_seq ? latest_seq : slave_ack_seq,
Comment thread
git-hulk marked this conversation as resolved.
slave_ack_seq >= latest_seq ? 0 : latest_seq - slave_ack_seq));
++idx;
}
entries.emplace_back("master_repl_offset", latest_seq);
}

entries.emplace_back("master_repl_offset", latest_seq);

return entries;
}

Expand Down
Loading