Skip to content

fix(sideloading): avoid the expected data deletion during SST side loading#3342

Merged
git-hulk merged 4 commits into
apache:unstablefrom
ltagliamonte-dd:fix_sideloading
Jan 21, 2026
Merged

fix(sideloading): avoid the expected data deletion during SST side loading#3342
git-hulk merged 4 commits into
apache:unstablefrom
ltagliamonte-dd:fix_sideloading

Conversation

@ltagliamonte-dd
Copy link
Copy Markdown
Contributor

@ltagliamonte-dd ltagliamonte-dd commented Jan 16, 2026

Hello folks,
we think we may experiencing data deletion during expensive (thousand of sst files) sst side loading operations.
what we think it is happening is:

  • T1 - load data CF
  • T2 - auto compactions runs which deletes the data as keys on the metadata CF are not yet loaded
  • T3 - load metadata CF

for this reason we would love to switch the sst ingestion logic to use IngestExternalFiles that should take care of sideloading all files from different CF atomically.

@ltagliamonte-dd ltagliamonte-dd changed the title use IngestExternalFiles perf(sideloading): use IngestExternalFiles Jan 16, 2026
@ltagliamonte-dd
Copy link
Copy Markdown
Contributor Author

ltagliamonte-dd commented Jan 16, 2026

@aleksraiden would you mind run the CI for this so i can test a nightly build?

@ltagliamonte-dd ltagliamonte-dd changed the title perf(sideloading): use IngestExternalFiles fix(sideloading): use IngestExternalFiles Jan 16, 2026
@ltagliamonte
Copy link
Copy Markdown

@git-hulk thanks for the CI run, the failures look like flaky isn't it?
Where can I find the nightly build for latest Sha?

@git-hulk
Copy link
Copy Markdown
Member

@ltagliamonte-dd Yes, this test failure is not related to this PR.

Where can I find the nightly build for latest SHA?

The Docker nightly build can only get after merging the PR. But you can also build it manually and push it to your own Docker repository if you're in a hurry to have a test.

@ltagliamonte
Copy link
Copy Markdown

Thank you @git-hulk , do you mind reviewing and maybe ping someone else so we can get this merged?
It should be pretty straightforward we aren't changing the behavior and the test pass.
Thanks!

Comment thread src/storage/storage.cc Outdated
@git-hulk git-hulk changed the title fix(sideloading): use IngestExternalFiles fix(sideloading): avoid the expected data deletion during SST side loading Jan 21, 2026
@git-hulk git-hulk enabled auto-merge (squash) January 21, 2026 02:23
@git-hulk git-hulk merged commit 7ed063a into apache:unstable Jan 21, 2026
38 checks passed
@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 50%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants