fix(sideloading): avoid the expected data deletion during SST side loading#3342
Merged
Conversation
Contributor
Author
|
@aleksraiden would you mind run the CI for this so i can test a nightly build? |
|
@git-hulk thanks for the CI run, the failures look like flaky isn't it? |
Member
|
@ltagliamonte-dd Yes, this test failure is not related to this PR.
The Docker nightly build can only get after merging the PR. But you can also build it manually and push it to your own Docker repository if you're in a hurry to have a test. |
|
Thank you @git-hulk , do you mind reviewing and maybe ping someone else so we can get this merged? |
git-hulk
reviewed
Jan 20, 2026
568f414 to
a0949b3
Compare
git-hulk
approved these changes
Jan 21, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Hello folks,
we think we may experiencing data deletion during expensive (thousand of sst files) sst side loading operations.
what we think it is happening is:
for this reason we would love to switch the sst ingestion logic to use IngestExternalFiles that should take care of sideloading all files from different CF atomically.