fix(string): add empty string value check for INCR to match Redis behavior#3354
Merged
Merged
Conversation
|
git-hulk
approved these changes
Jan 29, 2026
git-hulk
changed the title
nagisa-kunhah
pushed a commit
to nagisa-kunhah/kvrocks
that referenced
this pull request
Apr 29, 2026
…avior (apache#3354) ### Background Previously, Kvrocks allowed INCR on a key whose value was an empty string (""), treating it as zero and returning 1. In Redis, the same operation results in an error: ERR value is not an integer or out of range This difference caused inconsistent behavior between Kvrocks and Redis. ### Changes - Added check for empty string values before performing INCR - Return error when value is an empty string, matching Redis behavior ### Result Kvrocks now behaves consistently with Redis when performing INCR on empty string values, improving compatibility and reducing unexpected results in client applications. Co-authored-by: yxj25245 <yxj25245@ly.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Previously, Kvrocks allowed INCR on a key whose value was an empty string (""),
treating it as zero and returning 1.
In Redis, the same operation results in an error:
ERR value is not an integer or out of range
This difference caused inconsistent behavior between Kvrocks and Redis.
Changes
Result
Kvrocks now behaves consistently with Redis when performing INCR on empty string values,
improving compatibility and reducing unexpected results in client applications.