Compressing rolled files

[lraulea]

I'm really struggling to find a way to zip the rolled old fromFile, at the moment that log4net decides to rollover on date. I don't see any direct way to get notified if a log file was rolled, only indirectly and incomplete.

My kind request is to implement ALT-3, if possible.

ALT-1: override RollOverRenameFiles() method

protected override void RollOverRenameFiles(string baseFileName)
{
    base.RollOverRenameFiles(baseFileName);
    //do zip
}

Result= NOK
-only works for rollover based on size
-for rollover based on date, this method is not called, no zip

ALT-2: override AdjustFileBeforeAppend() method

protected override void AdjustFileBeforeAppend()
{
   var currentFile = File;
   base.AdjustFileBeforeAppend();
   if (!currentFile.Equals(File))
   {
      //do zip
   }
}

Result= NOK
-works for rollover based on size on same day
-when crossing a date boundary, currentFile differs from File => zip OK
-when starting the main app the next day, it misses the previous day file => no zip

ALT-3: override RollFile(string fromFile, string toFile) method

protected override void RollFile(string fromFile, string toFile)
{
   base.RollFile(string fromFile, string toFile);
   //do zip on 'fromFile'
}

Cannot override now because method is not virtual

So, my request is: could this RollFile() be made virtual?

Thanks!

Greetings,
Liviu

[FreeAndNil]

@lraulea can you take a look at #205 and #206 ?
Does this solve your problem?

[lraulea]

@FreeAndNil thanks for replying!

Short answer = No

I was already aware of this feature (it is my ALT-1 above) but unfortunately it does not cover the rolling-on-date use case. Only works on rolling-on-size. As I saw during my testing.

So, I'd like to override a method that log4net calls exactly one time when log4net decides to roll (on size or on date). My impression is that this method is RollFile() but a different method that carries the fromFile is also ok for me.

[FreeAndNil]

@lraulea I got it.
Does #237 fix your problem?

[lraulea]

@FreeAndNil thanks for the quick modification of the code!

I've seen the code change, it is what I think it could solve my problem.

To be sure it fixes my problem, I need to test it in my environment and see the zips being created.

I'm using now a nuget package reference in my project, would it be possible to create a beta log4net nuget package for testing?

[FreeAndNil]

@lraulea I've published https://github.com/apache/logging-log4net/releases/tag/rc%2F3.0.5-preview.1
Nuget: https://www.nuget.org/packages/log4net/3.0.5-preview.1

[lraulea]

@FreeAndNil Excellent! Thank you.

Let me test it tomorrow. I'll get back with the test results.

[lraulea]

Unfortunately ALT-3, overriding RollFile(string fromFile, string toFile) does not work :-( pity

I see the new rolled files being created in File Explorer, but for some reason the RollFile() method is never called, not on rollover on size, not on rollover on time, . . .

I see the overriding of RollOverRenameFiles() method being called (only upon rollover on size, not on date).

@FreeAndNil Any thoughts? How to create a zip of the oldFile when log4net decides to roll (on size or date)?

[FreeAndNil]

@lraulea can you set a breakpoint in RollOverTime()?
Can you post your log4net configuration?

[lraulea]

@FreeAndNil Sure, let me check it tomorrow.

[lraulea]

Below the configuration data

Still TODO: set a breakpoint in RollOverTime()

class CustomRollingFileAppender : RollingFileAppender
{
    public CustomRollingFileAppender(CustomAppender customAppender)
    {
        //create new PaternLayout, .AddConverter, .ActivateOptions
        Name = customAppender.Name;
        AppendToFile = true;
        File = customAppender.File;
        DatePattern = "'-'yyyyMMdd"; //for testing = "'-'yyyyMMddHH"
        PreserveLogFileNameExtension = false;
        CountDirection = 0;
        Layout = patternLayout;
        ImmediateFlush = true;
        MaxSizeRollBackups = -1;  //managed outside log4net
        MaximumFileSize = "256MB";
        RollingStyle = RollingMode.Composite;
        StaticLogFileName = false;
    }

    protected override void RollFile(string fromFile, string toFile)
    {
        base.RollFile(fromFile, toFile);
        //log to a logfile1 fromFile param
        //logfile1 empty
    }

    protected override void RollOverRenameFiles(string baseFileName)
    {
        base.RollOverRenameFiles(baseFileName);
        //log to logfile2 baseFileName param
        //logfile2 only contains entries from rollover on size
    }

    protected override void AdjustFileBeforeAppend()
    {
        var currentFile = File;
        base.AdjustFileBeforeAppend();
        if (!currentFile.Equals(File))
        {
            //log to logfile3 currentFile, File params
            //logfile3 only contains entries from rollover on size
            //AdjustFileBeforeAppend called on rollover on time, but currentFile == File
        }
    }
}