[MJAR-49] Jarsigner fails on windows due to spaces in pathnames

[jira-importer]

John Taylor opened MJAR-49 and commented

This is a problem uncovered while running the latest (1.0-20060307.100605-1) version of the webstart plugin, which uses the jar plugin to sign jars. During the signing stage maven fails with
[debug] jarsigner executable=[C:\Program Files\Java\jdk1.5.0_06\jre..\bin\jarsigner.exe]
[debug] Signing JAR in-place (overwritting original JAR).
[warn] 'C:\Program' is not recognized as an internal or external command,
[warn] operable program or batch file.
[INFO] ------------------------------------------------------------------------
[ERROR] BUILD ERROR
[INFO] ------------------------------------------------------------------------
[INFO] Result of "C:\Program Files\Java\jdk1.5.0_06\jre..\bin\jarsigner.exe" -verbose -keystore "C:\Documents and Settings\jdt.keystore" -storepass ****** -keypass ****** E:\jdt\data\workspace\tabview\tabview-webstart\target\jnlp\commons-logging-1.0.3.jar roe execution is: '1'.
[INFO] ------------------------------------------------------------------------
(full trace is attached).

It looks as though the plexus utils classes are tokenizing the path to the jarsigner executable wrongly due to it containing spaces.

---

Affects: 2.1

Attachments:

• pathproblem.txt (48.44 kB)

Issue Links:

• MNG-2828 Upgrade the dependency on plexus-utils to a more recent version

1 votes, 1 watchers

[jira-importer]

Jerome Lacoste commented

Looking at the plexus code, I believe the problem may be fixed by forcing the upgrade to plexus >= 1.2 (where the shell element was introduced).

Could you try building a local maven-jar-plugin that reuses the latest plexus and see if that fixes your issue ?

[jira-importer]

John Taylor commented

OK, this might not have been the right way to do it, but I hand-edited the pom for the jar plugin in my local repo and added
<dependency>
<groupId>org.codehaus.plexus</groupId>
<artifactId>plexus-utils</artifactId>
<version>[1.2,]</version>
</dependency>

I then cleared out the plexus utils jars in my local repo to see what would be downloaded.

Rerunning the webstart plugin gave the same problem, and the repo was repopulated with plexus-utils versions 1.0.4, 1.1, 1.0.5, 1.2 and 1.2-SNAPSHOT.

John

[jira-importer]

Jerome Lacoste commented

You might want to run mvn with -X option to see where each version of plexus-utils got used.

[jira-importer]

Brett Porter commented

the version of plexus-utils used will always be the one in $MAVEN_HOME/lib, unfortunately

[jira-importer]

Jerome Lacoste commented

I believe that Brett's last comment is no longer valid starting from maven 2.0.6.

We could bump the plexus utils version to at least 1.4.2 to make sure this is fixed. (there was a regression between I think 1.2 and 1.4.1).

[jira-importer]

Jerome Lacoste commented

I seem to have similar problems with other plugins. But I've upgraded them to p-u 1.4.2 so it's perhaps not sufficient.
I don't run Windows so I don't see those issues. In a tentative to work around the problems encountered in the other plugins, I've bumped p-u to 1.4.8. See MWEBSTART-60 as an example.

[jira-importer]

Jerome Lacoste commented

Olivier, according to my users, upgrading to 1.4.8 fixed their problems.

[jira-importer]

Olivier Lamy commented

if we upgrade to p-u 1.4.8 we had to add a prerequisites to 2.0.6.
I have started to work on that but this upgrade causes some failures on the it tests.
Some tests use MavenEmbedder which causes some failures here.
This means some its tests need to be rewritte with using maven-invoker-plugin.

[jira-importer]

Olivier Lamy commented

fixed in rev 602261.
snapshot deployed maven-jar-plugin 2.2-20071207.230654-4.
If any trouble reopen the issue.

[jira-importer]

Stanislav Spiridonov commented

I have a trouble

[INFO] Scanning for projects...

[INFO] ----------------------------------------------------------------------------

[INFO] Building Flexess: JCE provider

[INFO] task-segment: [clean, deploy]

[INFO] ----------------------------------------------------------------------------

[INFO] snapshot org.apache.maven.plugins:maven-jar-plugin:2.2-SNAPSHOT: checking for updates from jinternal-sn

[INFO] snapshot org.apache.maven.plugins:maven-jar-plugin:2.2-SNAPSHOT: checking for updates from jopen-sn

[INFO] snapshot org.apache.maven.plugins:maven-jar-plugin:2.2-SNAPSHOT: checking for updates from apache snapshot repository

[INFO] snapshot org.apache.maven.plugins:maven-jar-plugin:2.2-SNAPSHOT: checking for updates from codehaus snapshot repository

[INFO] snapshot org.apache.maven.plugins:maven-jar-plugin:2.2-SNAPSHOT: checking for updates from codehaus-release-repo

[INFO] snapshot org.apache.maven.plugins:maven-jar-plugin:2.2-SNAPSHOT: checking for updates from java.net

[INFO] snapshot org.apache.maven.plugins:maven-jar-plugin:2.2-SNAPSHOT: checking for updates from spring-ext

Downloading: http://people.apache.org/repo/m2-snapshot-repository/org/apache/maven/plugins/maven-jar-plugin/2.2-SNAPSHOT/maven-jar-plugin-2.2-20071207.230654-4.pom

7K downloaded

Downloading: http://people.apache.org/repo/m2-snapshot-repository/org/apache/maven/plugins/maven-jar-plugin/2.2-SNAPSHOT/maven-jar-plugin-2.2-20071207.230654-4.jar

25K downloaded

[INFO] [clean:clean]

[INFO] Deleting directory /var/data/maven/hudson/jobs/Jresearch Flexess/workspace/new_root/general/1.0.0/../../license/trunk/pom/../provider/target

[INFO] Deleting directory /var/data/maven/hudson/jobs/Jresearch Flexess/workspace/new_root/general/1.0.0/../../license/trunk/pom/../provider/target/classes

[INFO] Deleting directory /var/data/maven/hudson/jobs/Jresearch Flexess/workspace/new_root/general/1.0.0/../../license/trunk/pom/../provider/target/test-classes

[INFO] Deleting file-set: /var/data/maven/hudson/jobs/Jresearch Flexess/workspace/new_root/general/1.0.0/../../license/trunk/pom/../provider/bin (included: [], excluded: [])

[INFO] Preparing source:jar

[WARNING] Removing: jar from forked lifecycle, to prevent recursive invocation.

[INFO] [org.jresearch.commons.obfuscate.:check {execution: default}]

[INFO] Skip the obfuscating activity for the project com.jresearchsoft.uam.license:com.jresearchsoft.uam.license.provider:1.0.0-SNAPSHOT - disable

[INFO] [source:jar {execution: attach-sources}]

[INFO] Building jar: /var/data/maven/hudson/jobs/Jresearch Flexess/workspace/new_root/general/1.0.0/../../license/trunk/pom/../provider/target/com.jresearchsoft.uam.license.provider-1.0.0-SNAPSHOT-sources.jar

[INFO] [org.jresearch.commons.obfuscate.:check {execution: default}]

[INFO] Skip the obfuscating activity for the project com.jresearchsoft.uam.license:com.jresearchsoft.uam.license.provider:1.0.0-SNAPSHOT - disable

[INFO] [resources:resources]

[INFO] Using default encoding to copy filtered resources.

[INFO] [compiler:compile]

Compiling 10 source files to /var/data/maven/hudson/jobs/Jresearch Flexess/workspace/new_root/general/1.0.0/../../license/trunk/pom/../provider/target/classes

[INFO] [resources:testResources]

[INFO] Using default encoding to copy filtered resources.

[INFO] [compiler:testCompile]

Compiling 4 source files to /var/data/maven/hudson/jobs/Jresearch Flexess/workspace/new_root/general/1.0.0/../../license/trunk/pom/../provider/target/test-classes

[INFO] [surefire:test]

[INFO] Tests are skipped.

Downloading: http://server.jresearch.org:28080/internal-snapshot//org/apache/maven/plugins/maven-jar-plugin/2.2-SNAPSHOT/maven-jar-plugin-2.2-20071207.230654-4.pom

Downloading: http://www.jresearch.org/open-snapshot/org/apache/maven/plugins/maven-jar-plugin/2.2-SNAPSHOT/maven-jar-plugin-2.2-20071207.230654-4.pom

Downloading: http://people.apache.org/repo/m2-snapshot-repository/org/apache/maven/plugins/maven-jar-plugin/2.2-SNAPSHOT/maven-jar-plugin-2.2-20071207.230654-4.pom

7K downloaded

[INFO] [jar:jar]

[INFO] Building jar: /var/data/maven/hudson/jobs/Jresearch Flexess/workspace/new_root/general/1.0.0/../../license/trunk/pom/../provider/target/com.jresearchsoft.uam.license.provider-1.0.0-SNAPSHOT.jar

[INFO] [jar:sign {execution: default}]

[debug] jarsigner executable=[/usr/jdk/instances/jdk1.5.0/jre/../bin/jarsigner]

[debug] Executing: /bin/sh -c 'cd /var/data/maven/hudson/jobs/Jresearch Flexess/workspace/new_root/general/1.0.0/../../license/trunk/pom/../provider && /usr/jdk/instances/jdk1.5.0/jre/../bin/jarsigner -verify -verbose "/var/data/maven/hudson/jobs/Jresearch Flexess/workspace/new_root/general/1.0.0/../../license/trunk/pom/../provider/target/com.jresearchsoft.uam.license.provider-1.0.0-SNAPSHOT.jar"'

[warn] /bin/sh: /var/data/maven/hudson/jobs/Jresearch: does not exist

[INFO] ------------------------------------------------------------------------

[ERROR] BUILD ERROR

[INFO] ------------------------------------------------------------------------

[INFO] Result of /bin/sh -c 'cd /var/data/maven/hudson/jobs/Jresearch Flexess/workspace/new_root/general/1.0.0/../../license/trunk/pom/../provider && /usr/jdk/instances/jdk1.5.0/jre/../bin/jarsigner -verify -verbose "/var/data/maven/hudson/jobs/Jresearch Flexess/workspace/new_root/general/1.0.0/../../license/trunk/pom/../provider/target/com.jresearchsoft.uam.license.provider-1.0.0-SNAPSHOT.jar"' execution is: '1'.

[INFO] ------------------------------------------------------------------------

[INFO] For more information, run Maven with the -e switch

[INFO] ------------------------------------------------------------------------

[INFO] Total time: 31 seconds

[INFO] Finished at: Sun Dec 09 17:54:44 CET 2007

[INFO] Final Memory: 11M/26M

[INFO] ------------------------------------------------------------------------

[jira-importer]

Olivier Lamy commented

Looks to be related to PLXUTILS-54.
Can you test without spaces in your directory name because I see "bin/sh -c 'cd /var/data/maven/hudson/jobs/Jresearch Flexess/workspace/new_root/genera....."
And not in a hudson context
Thanks.

[jira-importer]

Olivier Lamy commented

upgrade to last p-u looks to cause failures on unix platform.

[jira-importer]

Olivier Lamy commented

I have updated plexus-utils dependency version to last SNAPSHOT (see PLXUTILS-54) which should fix this.
Can you try and give feedback ?
Thanks in advance.

[jira-importer]

Stanislav Spiridonov commented

Yes it works for me (with 2.2-20071210.234803-5)

[jira-importer]

Olivier Lamy commented

Closed it due to positive feeback from user.
Thanks for your tests.