[MJAR-71] use manifest in classesdir/META-INF if exists

[jira-importer]

Carlos Sanchez Gonzalez opened MJAR-71 and commented

With 2.1 I need to add this to the pom to use the manifest that it's already in the classes folder, make this the default

<plugin>
  <groupId>org.apache.maven.plugins</groupId>
  <artifactId>maven-jar-plugin</artifactId>
  <version>2.1</version>
  <configuration>
    <archive>
      <manifestFile>${project.build.outputDirectory}/META-INF/MANIFEST.MF</manifestFile>
    </archive>
  </configuration>
</plugin>

---

Affects: 2.1

Attachments:

• MJAR-71-disabled_by_default.diff (12.93 kB)
• MJAR-71-enabled_by_default.diff (12.93 kB)

[jira-importer]

Dennis Lundberg commented

This can potentially break backwards compatibility. We probably need to have a boolean parameter to turn this on, with off being the default behavior. Something like useDefaultManifestFile.

[jira-importer]

Jerome Lacoste commented

Here's a tentative fix for the issue. I've made 2 versions, one where the feature is enabled by default, one disabled by default.

[jira-importer]

Jerome Lacoste commented

Please comment on the approach and the parameters. I can provide documentation later on if the approach seems sane.

[jira-importer]

Olivier Lamy commented

Thanks for patch but I'm not sure adding a new parameter to set the default manifest file is needed.
Because the manifestFile configuration is in the the archive configuration part.
Something with readonly should be better like

/**
 * Path to the default MANIFEST file to use will be use if useDefaultManifestFile is set to true
 *
 * @parameter expression="${project.build.outputDirectory}/META-INF/MANIFEST.MF"
 * @required
 * @readonly
 */
 private File defaultManifestFile;
/**
 * Set to true to enable the use of the defaultManifestFile
 *
 * @parameter expression="${jar.useDefaultManifestFile}" default-value="false"
 */
private boolean useDefaultManifestFile;

And I have added a test to not override the manifestFile in the archive configuration if it exists.
Even if the user set useDefaultManifestFile to true.

[jira-importer]

Olivier Lamy commented

committed in rev 603097/603098.

[jira-importer]

Dennis Lundberg commented

Olivier, your example looks like what I had in mind. Thanks!