[MJAR-296] No way to suppress default excludes in maven-jar-plugin

[jira-importer]

G.Vaysman opened MJAR-296 and commented

With the default excludes being expanded further (see org.codehaus.plexus.util.AbstractScanner.{}DEFAULTEXCLUDES{}), a resource directory /ChangeSet/ will never be included in the JAR artifact.

Some plugins (maven-resources-plugin, maven-assembly-plugin) already allow suppressing the exclusion, but not the maven-jar-plugin. Code analysis of the JarMojo -> DirectoryScanner call path confirms that there is no way to affect the FileSet configuration. 

Again, with ever expanding list of DEFAULTEXCLUDES, this, on our opinion, is quite detrimental, and due to backward compatibility, changing resource/package path (say, to ChangeSet2) is not an option. 

I am attaching a very simple project that shows two things:

1. The jar plugin skips adding the /ChangeSet/ files
2. The resources plugin is configured not to skip (addDefaultExcludes) and behaves properly

---

Affects: 3.3.0

Attachments:

• jar-default-excludes.zip (5.79 kB)

Issue Links:

• MJAR-265 Resources not copied

Remote Links:

• GitHub Pull Request #67
  

[jira-importer]

Michael Osipov commented

I don't consider this as a bug because the absence of a feature is not a bug. Your request makes sense, though.

[jira-importer]

Michael Osipov commented

Can you provide a patch which behaves identical to the other plugin you have mentioned along with an IT? I'd be willing to review!

[jira-importer]

Tomasz Reg commented

I took the liberty of proposing an implementation for such a feature.
Michael Osipov please take a look when available: #67.