[MRELEASE-1109] update-versions removes the CI-friendly ${revisions}

[jira-importer]

Marcel Stör opened MRELEASE-1109 and commented

Given: a project using CI-friendly versions as per https://maven.apache.org/maven-ci-friendly.html

  <version>${revision}</version>
  ...
  <properties>
    <revision>1.0.0-SNAPSHOT</revision>
  </properties>

If I run mvn release:update-versions (with or without {}-DautoVersionSubmodules=true{}) I expect the release plugin to change the $revision property. Instead it blindly replaces <version>${revision}</version> with the hard-coded version set on the CLI.

---

Affects: 2.5.3, 3.0.0-M7

Issue Links:

• MRELEASE-1154 [REGRESSION] MRELEASE-1109 breaks release of Maven Surefire
  ("causes")
• MRELEASE-1151 [REGRESSION] Maven Release Plugin fails to adjust version
  ("causes")
• MRELEASE-1153 Revert parts of MRELEASE-1109 (8dfcb47) due to a regression
  ("causes")

Remote Links:

• GitHub Pull Request #198
  
• GitHub Pull Request #201
  
• GitHub Pull Request #202
  

[jira-importer]

Konrad Windszus commented

The same is true for release:prepare-release which is sometimes helpful even with CI friendly versions (e.g. for automatically updating property project.build.outputTimestamp, https://maven.apache.org/guides/mini/guide-reproducible-builds.html)

[jira-importer]

Konrad Windszus commented

The logic for rewriting the version at

maven-release/maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/AbstractRewritePomsPhase.java

Line 443 in 0fae89d

private String rewriteParent(

needs to be extended to treat ci-friendly ones specially like it is currently done in https://github.com/eclipse-tycho/tycho/blob/2fcedecf38bf6244b911d486a6d8abd8c19ce5d8/tycho-versions-plugin/src/main/java/org/eclipse/tycho/versions/manipulation/PomManipulator.java#L88

[jira-importer]

Konrad Windszus commented

Fixed in 9e0713b.

[jira-importer]

Basil Crow commented

Causes MRELEASE-1151.