[MRELEASE-1119] release plugin ignores developmentVersion

[jira-importer]

Robert Patrick opened MRELEASE-1119 and commented

I just ran a release process using the 3.0.0 version of the maven-release-plugin with a release.properties file like this:

tag=release-3.0.4
releaseVersion=3.0.4
developmentVersion=3.1.0-SNAPSHOT

After running mvn -B release:prepare release:perform, the pom.xml version is 3.0.5-SNAPSHOT. 

---

Affects: 3.0.0

[jira-importer]

Michael Osipov commented

Does it work with M7?

[jira-importer]

Robert Patrick commented

No

On Tue, Mar 21, 2023 at 2:29 AM Michael Osipov (Jira) jira@apache.org

[jira-importer]

Karl Heinz Marbaise commented

Hi Robert Patrick Have you called the release plugin via:

mvn -Drelease=... -DdevelopmentVersion=3.1.0-SNAPSHOT release:prepare release:perform

Can you give more context on the problem maybe an example project? I've created an IT's which seemed to be working...

[jira-importer]

Robert Patrick commented

No, I have not. No one wants to type a big long command line when this has
been advertised as working for years and does work provided you only
increment the last digit. As soon as you try to do anything else, it
ignores what you tell it and increments the last digit.

See https://github.com/oracle/weblogic-deploy-tooling

On Wed, Apr 12, 2023 at 6:14 PM Karl Heinz Marbaise (Jira) jira@apache.org

[jira-importer]

Karl Heinz Marbaise commented

The question is not if you like to type that. I have asked how you have called the maven-release-plugin? Via configuraiton in pom file or how? If I take the not existing configuration in the referernced project it can not change the developmentVersion like that because it's not defined at all which means it uses the defaults which means simply incrementing the patch version...

[jira-importer]

Robert Patrick commented

I just ran a release process using the 3.0.0 version of the maven-release-plugin with a release.properties file like this:

tag=release-3.0.4
releaseVersion=3.0.4
developmentVersion=3.1.0-SNAPSHOT

After running {}mvn -B release:prepare release:perform{}, the pom.xml version is 3.0.5-SNAPSHOT. 

Karl Heinz Marbaise I thought I was very clear in the original description.

1. In basedir, I created a release.properties file with the tag, releaseVersion, and developmentVersion properties defined in it.
2. From the command-line at the basedir, I ran:   mvn -B release:prepare release:perform

The root level POM has a declaration for the maven-release-plugin.  No profiles or anything relevant in settings.xml

[jira-importer]

Robert Patrick commented

I just created a very simple project–nothing but a pom.    

https://github.com/robertpatrick/mrp-test

The initial commit was at version 3.0.4-SNAPSHOT.

{}I created the release.properties file in the basedir with the following contents:{}{}{}

tag=release-3.0.4
releaseVersion=3.0.4
developmentVersion=3.1.0-SNAPSHOT

Ran: mvn -B release:prepare release:perform

Same issue.  After the release process finished, the pom version is 3.0.5-SNAPSHOT.

 

 

 

[jira-importer]

Karl Heinz Marbaise commented

Ah great Robert Patrick thanks for those detailed information that helps a lot to understand your problem. The issue was that your release.properties did not contained the correct information... if you create a release.properties file like this:

scm.tag=release-3.0.4
project.dev.org.apache.maven.plugin.release.its\:mrelease-1119=3.1.0-SNAPSHOT
project.rel.org.apache.maven.plugin.release.its\:mrelease-1119=3.0.4

where the part: org.apache.maven.plugin.release.its represents the groupId of your project and the mrelease-1119 is the artifactId of your project. The prefixing part project.dev. is the development version and the project.rel. is the project release version. By using that it creates the correct results.

By using the wrong release.properties the integration tests exactly shows the described (from your point of view) wrong behaviour. Using the correct content it behaves exactly as it should...

So the release.properties file for your test project (mrpm-test) should look like this:(assumed your starting version in your project is 3.0.4-SNAPSHOT):

scm.tag=release-3.0.4
project.dev.io.rhpatrick.test\:mrp-test=3.1.0-SNAPSHOT
project.rel.io.rhpatrick.test\:mrp-test=3.0.4

This is also documented here: https://maven.apache.org/maven-release/maven-release-plugin/usage/non-interactive-release.html#using-a-properties-file

It might be easier to just define the new development version via command like this: mvn -B -DdevelopmentVersion=3.1.0-SNAPSHOT release:prepare release:perform and the rest will be taken from the pom.xml and the increment will be done by default on the patch level...

[jira-importer]

Robert Patrick commented

That is really ugly.  The property file I showed works perfectly fine except when changing the development version.  Not sure I understand why the same system properties you use on the command-line cannot be used in the release.properties file.  Seems like everything expect the developmentVersion is already working using the old approach I was using.  If this were my project, I would treat that as a bug...   

[jira-importer]

Karl Heinz Marbaise commented

No. The property file contained the same versions as your pom file already contained (next release versions implied by the existing SNAPSHOT versions) which looks like it's working but it does not working that way. Just set your version in your pom file to lets say 3.2.0-SNAPSHOT commit that and then define the content of your release.properties file with the following:

tag=release-3.3.0
releaseVersion=3.3.0
developmentVersion=3.4.0-SNAPSHOT

and just try to run: mvn -B release:prepare and look in the pom and the created tag etc... it will tag: 3.2.0 and your pom (last commit will be 3.2.0) etc. so not workgin at all...as documented...
If you in contradiction fill the release.properties file with correct key/value pairs like this:

scm.tag=release-3.3.0
project.dev.io.rhpatrick.test\:mrp-test=3.4.0-SNAPSHOT
project.rel.io.rhpatrick.test\:mrp-test=3.3.0

and run mvn -B release:prepare you will see the difference...