Skip to content

Don't catch Throwable #1301

@elharo

Description

@elharo

Affected version

head

Bug description

We do this

        } catch (Throwable t) {
            onExit(-1, t.getClass().getSimpleName());
        }

in at least one place in GitPackCommand and in HgScmProvider. see https://stackoverflow.com/questions/6083248/is-it-a-bad-practice-to-catch-throwable for reasons not to do this

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions