GitPackCommand opens Repository without closing it

[kwin]

Version

2.15.1-SNAPSHOT

Bug description

The GitPackCommand opens a repository in

mina-sshd/sshd-git/src/main/java/org/apache/sshd/git/pack/GitPackCommand.java

Line 85 in 67e2e4c

Repository db = key.open(true /* must exist */);

but never closes it accordingly, which leads to dangling file handles and problems when deleting the repository directory on Windows.

Actual behavior

Once you stop the minimal Git SSH server and try to delete the underlying FS directory you observe the following on Windows:

java.io.IOException: File D:\a\maven-scm\maven-scm\maven-scm-providers\maven-scm-providers-git\maven-scm-provider-gitexe\target\scm-test\repository\objects\pack\pack-eef7d0ee953db4f2dd2cdc2c2fb2bcd53123a248.pack unable to be deleted.

(e.g. in https://github.com/apache/maven-scm/actions/runs/16597578214/job/46948644603?pr=1270)

Expected behavior

Every repository which is opened should also be closed afterwards.

Relevant log output

Other information

No response

[tomaswolf]

Note that pack files in git are also read-only, which may give trouble deleting them on Windows.

[kwin]

I used java.io.File API which till recently also worked on read-only files (https://bugs.openjdk.org/browse/JDK-8355954). Still I faced the issue, so I think this is really about cached files being kept open by the underlying repository.

[tomaswolf]

I'm not disputing that at all, just pointing out another potential problem with deleting git repositories.