GH-628: Fix reading directories with trailing blanks in the name

[tomaswolf]

ValidateUtils.checkNotNullAndNotEmpty(String, ...) as a side-effect returns the trimmed string!

Add new methods ValidateUtils.hasContent(String, ...) that don't do so, and use that instead.

Fixes #628.

[dadoonet]

Thanks a lot!

[tomaswolf]

Thank you; you're welcome. Caused by poor coding in ages-old code; one really wouldn't expect a method named "checkNotNullAndNotEmpty" to have such a side effect.

[dadoonet]

@tomaswolf Any idea of when you will most likely be releasing a new version?

[tomaswolf]

Short answer: end of January or first half of February 2025, but that's my personal goal only.

Long answer:

We don't have a fixed release plan. There's no organization large enough backing this project that would provide reliable manpower for regular releases. It's all individual volunteer effort; releases being done by @gnodet, and before being published releases have to go through a review and voting phase by the MINA PMC. Even if Guillaume might have time to cut a 2.14.2 release now, I don't know if the other PMC members would have time to review it. I know that I am unlikely to have that time this month.

With my Eclipse developer hat on, I'd like to include a new release of Apache MINA sshd in JGit and in Eclipse for its next release (March 12, 2025). Which means I aim for a 2.15.0 release around end of January 2025. 2.15.0 should include PR #639 and it should be prepared to work with or without SecurityManager, which AFAIK will finally disappear in Java 24 (also March 2025).

This fix here is already available in the snaphot release from the Apache snapshots repository. As a stop-gap measure you might just use that.

[dadoonet]

Thanks! It's helpful.

it should be prepared to work with or without SecurityManager

Yeah. I'm sad this has been removed from the JVM. It was so useful for Elastic and that's how we did not suffer from the Log4Shell disaster...