GH-626: Enable Streaming.Async for ChannelDirectTcpip#631
Merged
Conversation
ChannelDirectTcpip gives user code the ability to request a direct-tcpip forward explicitly, without listener on a local port. (Full local port forwarding with a listener on the local port is not implemented in ChannelDirectTcpip but in TcpipClientChannel.) Complete the implementation to also support the asynchronous asyncIn and asyncOut streams. Factor out the stream setup from ChannelSession into a new intermediary class, and derive ChannelDirectTcpip from that new class. (Basing it on ChannelSession directly would be wrong; the channel would end up with the wrong type and also inherit the setEnv() method.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ChannelDirectTcpip gives user code the ability to request a direct-tcpip forward explicitly, without listener on a local port. (Full local port forwarding with a listener on the local port is not implemented in ChannelDirectTcpip but in TcpipClientChannel.)
Complete the implementation to also support the asynchronous asyncIn and asyncOut streams. Factor out the stream setup from ChannelSession into a new intermediary class, and derive ChannelDirectTcpip from that new class. (Basing it on ChannelSession directly would be wrong; the channel would end up with the wrong type and also inherit the setEnv() method.)
Fixes #626.