ScpShell fixes; SFTP append mode for buggy servers#696
Merged
Conversation
Member
tomaswolf
commented
Mar 15, 2025
tomaswolf
commented
- Fix current directory handling in SCPShell for WinSCP
- Better handle SFTP append in SFTPv3 for buggy servers: send reasonable write offsets
Some SFTP v3 servers have trouble with append mode for file uploads. OpenSSH < 6.3 didn't have append mode implemented, and some server identifying as "7.9.0.0_openssh" apparently also cannot do it. As a work-around get the file size first, then use that as base offset for writing. This is at best an approximation of true append mode. We still send the "append" flag, so for correct servers there will be no change, but with the work-around appending may work as expected in most cases even for servers that get append mode wrong.
Fix the handling of the home directory when a RootedFileSystem is used. 'currentDir' and 'homeDir' must be paths from the file system used. WinSCP may, at least initially, send Windows-style paths; so ensure that the path is converted. When listing the root directory, don't include the ".." entry for the parent directory. Tested manually on Windows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.