[GH-725] Added commandTimeoutMillis in executeRemoteCommand

[raajeive]

Added commandTimeoutMillis in executeRemoteCommand

Implemets #725

[tomaswolf]

This needs a test, and must be done in a way that is backwards-compatible.

[raajeive]

Hi @tomaswolf i have addressed all the comments provided, Can you please check this now?

[garydgregory]

Hi all,

I think we should stop using ints and longs to express durations ASAP. Java has Duration class, let's use it. If a duration ends up as int seconds or long milliseconds or whatever scale a low level API in Java needs, that's fine, I just feel there is still room for confusion using primitives. A Duration also offers the best precision on Java 9 and up (nanosecond).

[raajeive]

Hi @garydgregory

I've refactored the relevant code to use java.time.Duration instead of int/long for expressing timeouts. This should help improve clarity and avoid unit-related confusion going forward.

Would appreciate it if you could take a look and let me know if anything needs adjusting.

Thanks!

[raajeive]

Hi @tomaswolf @garydgregory,

Addressed all the comments, can you please check this and provide the approvals?

Thanks.

[tomaswolf]

Thank you!

[raajeive]

@tomaswolf @garydgregory @osi @knalli

When can we expect this to get released?