-
Notifications
You must be signed in to change notification settings - Fork 70
[feat][Message] Add getIndex method on Message #277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
54a1dc8
to
1e15921
Compare
@BewareMyPower PTAL |
eebba7f
to
32d22cc
Compare
BewareMyPower
previously requested changes
Jun 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.

You can see the BrokerEntryMetadata
was not added when messages were from the C++ producer.
From the server side, you can see:
if (cnx.getRemoteEndpointProtocolVersion() < ProtocolVersion.v18.getValue()
|| !cnx.supportBrokerMetadata()
|| !cnx.getBrokerService().getPulsar().getConfig()
.isExposingBrokerEntryMetadataToClientEnabled()) {
Commands.skipBrokerEntryMetadataIfExist(metadataAndPayload);
}
The client needs to set the feature flags in newConnect
, just like the Java client does:
private static void setFeatureFlags(FeatureFlags flags) {
flags.setSupportsAuthRefresh(true);
flags.setSupportsBrokerEntryMetadata(true);
flags.setSupportsPartialProducer(true);
}
59efecc
to
a449b62
Compare
dcdd19c
to
fe96af0
Compare
3a2dff7
to
c1bbcb1
Compare
c1bbcb1
to
bf6d2fd
Compare
ping @BewareMyPower |
BewareMyPower
approved these changes
Jun 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
After #276 , We already can consume messages contains index well. Now we can add a method allow user to getIndex.
Index is an optional brokerMetadata. If the index not exists, we will return -1
Verifying this change
Documentation
doc-required
(Your PR needs to update docs and you will update later)
doc-not-needed
(Please explain why)
doc
(Your PR contains doc changes)
doc-complete
(Docs have been already added)