Fix retriable errors not handled well when creating producer or consumer #293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes apache#292 ### Motivation When a consumer failed to subscribe due to a retriable error, the time point comparation is wrong: https://github.com/apache/pulsar-client-cpp/blob/633f4bbe8c182128da09803172676b9d6af05057/lib/ConsumerImpl.cc#L321 `creationTimestamp_ + operationTimeut_` is the deadline, `TimeUtils::now()` is the current time, we should use `>` instead of `<` here to compare them. Otherwise, if the consumer encountered a retriable error and the deadline is not exceeded, the consumer won't reconnect and fail with `ResultRetryable`. ### Modifications Reverse the comparation between the deadline and the current time. When it times out, completing the future with `ResultTimeout` instead of the `result` itself, which is always `ResultRetryable`. Add `ConsumerTest.testRetrySubscribe` to verify this change. ### TODO Support configuring the operation timeout in milliseconds.
BewareMyPower
requested review from
merlimat,
RobertIndie,
Demogorgon314 and
shibd
shibd
reviewed
Jun 28, 2023
BewareMyPower
changed the title
shibd
approved these changes
Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #292
Motivation
When a consumer failed to subscribe due to a retriable error, the time point comparation is wrong:
pulsar-client-cpp/lib/ConsumerImpl.cc
Line 321 in 633f4bb
creationTimestamp_ + operationTimeut_is the deadline,TimeUtils::now()is the current time, we should use>instead of<here to compare them. Otherwise, if the consumer encountered a retriable error and the deadline is not exceeded, the consumer won't reconnect and fail withResultRetryable.Modifications
Reverse the comparation between the deadline and the current time. When it times out, completing the future with
ResultTimeoutinstead of theresultitself, which is alwaysResultRetryable.Add
ConsumerTest.testRetrySubscribeto verify this change.TODO
Support configuring the operation timeout in milliseconds.
Documentation
doc-required(Your PR needs to update docs and you will update later)
doc-not-needed(Please explain why)
doc(Your PR contains doc changes)
doc-complete(Docs have been already added)