Fix the test script does not work for Docker on macOS #297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Motivation When I run `./pulsar-test-service-start.sh` on macOS m1 13.4, the standalone failed to start due to the wrong permission of the `test-conf` directory that is copied into the container via `docker cp`: ``` I have no name!@a00f70265760:/pulsar$ ls -l | grep test-conf drwx------ 3 501 dialout 4096 Jun 4 13:31 test-conf ``` It seems to be a bug: docker/for-mac#1814 ### Modifications Execute `docker run` with the current username via `id -u`.
shibd
approved these changes
Jul 6, 2023
BewareMyPower
added a commit
to BewareMyPower/pulsar-client-python
that referenced
this pull request
Nov 16, 2023
See apache/pulsar-client-cpp#297 ### Motivation When I run `./pulsar-test-service-start.sh` on macOS m1 13.4, the standalone failed to start due to the wrong permission of the `test-conf` directory that is copied into the container via `docker cp`: ``` I have no name!@a00f70265760:/pulsar$ ls -l | grep test-conf drwx------ 3 501 dialout 4096 Jun 4 13:31 test-conf ``` It seems to be a bug: docker/for-mac#1814 ### Modifications Execute `docker run` with the current username via `id -u`.
BewareMyPower
added a commit
to BewareMyPower/pulsar-client-python
that referenced
this pull request
Nov 16, 2023
Migrate the PRs from the pulsar-client-cpp repo: - apache/pulsar-client-cpp#297 - apache/pulsar-client-cpp#236 - apache/pulsar-client-cpp#340
BewareMyPower
added a commit
to apache/pulsar-client-python
that referenced
this pull request
Nov 16, 2023
Migrate the PRs from the pulsar-client-cpp repo: - apache/pulsar-client-cpp#297 - apache/pulsar-client-cpp#236 - apache/pulsar-client-cpp#340
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When I run
./pulsar-test-service-start.shon macOS m1 13.4, the standalone failed to start due to the wrong permission of thetest-confdirectory that is copied into the container viadocker cp:It seems to be a bug: docker/for-mac#1814
Modifications
Execute
docker runwith the current username viaid -u.Documentation
doc-required(Your PR needs to update docs and you will update later)
doc-not-needed(Please explain why)
doc(Your PR contains doc changes)
doc-complete(Docs have been already added)