Fix ProducerBusy or ConsumerBusy error when configuring multiple brokers per connection #337
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ers per connection ### Motivation This is a catch up for apache/pulsar#21144 When a producer or consumer reconnects, a random number will be generated as the key suffix in `ConnectionPool` to create or get the `ClientConnection` object from the pool. https://github.com/apache/pulsar-client-cpp/blob/81cc562f7b366fad97e1b80c07ef9334a808390d/lib/ConnectionPool.cc#L75 If a new connection is created with the same producer or consumer name to the broker, the broker will respond with a `ProducerBusy` or `ConsumerBusy` error so that the reconnection will never succeed. ### Modifications - Add an overload of `ConnectionPool::getConnectionAsync` that accepts an integer parameter as the key suffix. If it's not specified, generate the random number as the suffix. In this method, choose the executor by `key suffix % size`. - Generate the random number and save it when creating the `HandlerBase` object. When connecting the owner broker of its topic, pass that index so that the reconnection will always reuse the same `ClientConnection` object. ### Verifying this change `ProducerTest.testReconnectMultiConnectionsPerBroker` is added to protected the change.
BewareMyPower
force-pushed
the
bewaremypower/fix-same-producer
branch
from
f9621ef to
42f56c1
Compare
BewareMyPower
requested review from
RobertIndie,
Demogorgon314,
poorbarcode and
shibd
shibd
approved these changes
Nov 6, 2023
RobertIndie
approved these changes
Nov 7, 2023
BewareMyPower
added a commit
that referenced
this pull request
Nov 7, 2023
…ers per connection (#337) ### Motivation This is a catch up for apache/pulsar#21144 When a producer or consumer reconnects, a random number will be generated as the key suffix in `ConnectionPool` to create or get the `ClientConnection` object from the pool. https://github.com/apache/pulsar-client-cpp/blob/81cc562f7b366fad97e1b80c07ef9334a808390d/lib/ConnectionPool.cc#L75 If a new connection is created with the same producer or consumer name to the broker, the broker will respond with a `ProducerBusy` or `ConsumerBusy` error so that the reconnection will never succeed. ### Modifications - Add an overload of `ConnectionPool::getConnectionAsync` that accepts an integer parameter as the key suffix. If it's not specified, generate the random number as the suffix. In this method, choose the executor by `key suffix % size`. - Generate the random number and save it when creating the `HandlerBase` object. When connecting the owner broker of its topic, pass that index so that the reconnection will always reuse the same `ClientConnection` object. ### Verifying this change `ProducerTest.testReconnectMultiConnectionsPerBroker` is added to protected the change. (cherry picked from commit 6f115e7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This is a catch up for apache/pulsar#21144
When a producer or consumer reconnects, a random number will be generated as the key suffix in
ConnectionPoolto create or get theClientConnectionobject from the pool.pulsar-client-cpp/lib/ConnectionPool.cc
Line 75 in 81cc562
If a new connection is created with the same producer or consumer name to the broker, the broker will respond with a
ProducerBusyorConsumerBusyerror so that the reconnection will never succeed.Modifications
ConnectionPool::getConnectionAsyncthat accepts an integer parameter as the key suffix. If it's not specified, generate the random number as the suffix. In this method, choose the executor bykey suffix % size.HandlerBaseobject. When connecting the owner broker of its topic, pass that index so that the reconnection will always reuse the sameClientConnectionobject.Verifying this change
ProducerTest.testReconnectMultiConnectionsPerBrokeris added to protected the change.