Skip to content

[feat] PIP-307 added assigned broker urls for CloseProudcer and CloseConsumer commands and handler logic #389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jan 24, 2024

Conversation

heesung-sn
Copy link
Contributor

@heesung-sn heesung-sn commented Jan 22, 2024

Master Issue: #pip-307

Motivation

As part of PIP-307, I am adding the client logic to this c++ client.

Modifications

  • Added assigned broker urls to CloseProudcer and CloseConsumer commands.
  • Updated the client reconnection logic to directly connect to the assigned broker urls

Verifying this change

  • Make sure that the change passes the CI checks.

  • Added ExtensibleLoadManagerTest to cover this logic

Documentation

  • doc-required
    (Your PR needs to update docs and you will update later)

  • doc-not-needed
    (Please explain why)

  • doc
    (Your PR contains doc changes)

  • doc-complete
    (Docs have been already added)

@BewareMyPower BewareMyPower added this to the 3.5.0 milestone Jan 23, 2024
@heesung-sn heesung-sn changed the title [PIP-307] added assigned broker urls for CloseProudcer and CloseConsumer commands and handler logic [feat] PIP-307 added assigned broker urls for CloseProudcer and CloseConsumer commands and handler logic Jan 24, 2024
Copy link
Contributor

@BewareMyPower BewareMyPower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM except a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants