Add -Bsymbolic link option to avoid symbol interposition #432
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can also see https://github.com/BewareMyPower/symbol-interposition for the symbol interposition issue. |
merlimat
approved these changes
Jul 3, 2024
shibd
approved these changes
Jul 3, 2024
Demogorgon314
approved these changes
Jul 3, 2024
BewareMyPower
added a commit
to streamnative/pulsar-client-cpp
that referenced
this pull request
Jul 4, 2024
### Motivation There is a case that `libpulsar.so` could unexpectedly call functions from other dependencies. For example, assuming the application depends on two libraries: - `libpulsar.so`, which includes the symbols from `libcurl.a` 8.4.0 - `libfoo.so`, which includes the symbols from `libcurl.a` 7.82.0 If the link order is `libfoo.so` first, then the libcurl definitions from 7.82.0 will also be used by `libpulsar.so` and then the application might crash due to the incompatibility. This is an issue specifically with Linux ELF format. ### Modifications Add the `-Wl,-Bsymbolic` link option for GCC. (cherry picked from commit d736a1b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
There is a case that
libpulsar.socould unexpectedly call functions from other dependencies.For example, assuming the application depends on two libraries:
libpulsar.so, which includes the symbols fromlibcurl.a8.4.0libfoo.so, which includes the symbols fromlibcurl.a7.82.0If the link order is
libfoo.sofirst, then the libcurl definitions from 7.82.0 will also be used bylibpulsar.soand then the application might crash due to the incompatibility. This is an issue specifically with Linux ELF format.Modifications
Add the
-Wl,-Bsymboliclink option for GCC.