Skip to content

Reader interface #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 29 commits into
base: master
Choose a base branch
from
Open

Reader interface #1

wants to merge 29 commits into from

Conversation

lukfugl
Copy link

@lukfugl lukfugl commented Mar 20, 2020

Adds reader interface alongside producer and consumer.

lukfugl and others added 29 commits June 3, 2019 10:49
@lukfugl
initial PoC
24e6842 
can send from a producer and receive and acknowledge from a consumer
@lukfugl
promote String -> Message ruby-side
99494d7 
so that Producer::send can just take the Message cpp-side

also fix service_url handling in bin/example-*
@lukfugl
map ProducerConfiguration and default ruby-side
305ac81
@lukfugl
Client and Consumer configs in ruby
bd24044 
also, switch the using Module#prepend to decorate C++ defined methods
with ruby, rather than `_` prefixes
@lukfugl
negative_acknowledge not yet available
11eb701 
leave the placeholder in the C++ binding code, but don't actually bind
it, and don't use it in the example
@lukfugl
minor rework of commenting around negack TODOs
7eae2d2
@lukfugl
no explicit require_paths
1ea2d65 
to see if it makes a difference for where bundler puts the bindings.so
file. right now it's putting it in `lib/` instead of in `lib/pulsar/`
@lukfugl
fix extconf.rb for location of built bindings
e350d76
@lukfugl
add consumer.listen { |data| ... }
3d7c3d8
@lukfugl
typo
7a5fdca
@lukfugl
ClientConfiguration#authentication_token=
3405c2a
@lukfugl
clean up Client.new and consumer.listen
c6d912b 
and use them in the example producer and consumer
@lukfugl
Pulsar::Client.from_environment
83a210b 
and fix the topic name back to what it had been
@lukfugl
some touchup, ready for MVP
ca93b16
@lukfugl
handle Pulsar::ConsumerConfiguration.consumer_type
e61e002 
still allow passing in the enum value integer directly, but also for
convenience translate a set of symbols too and from the enum values
@lukfugl
enable negack now that 2.4 is released
d1460cb
@psi @lukfugl
Allow ConsumerType to be set in ConsumerConfiguration
030a881
@lukfugl
prep version 2.4.1-beta.1
cf70fd1
@lukfugl
release 2.4.1.pre.beta.1
bff9038
@lukfugl
fix c++ error handling a bit
f915f96
@ahuff44 @lukfugl
update readme basic example
c5b7f5c
@ahuff44 @lukfugl
fix listen_in_thread
8882f7d 
This should fix this error that I ran into when using listen_in_thread:
```
bundler: failed to load command: ./client.rb (./client.rb)
LocalJumpError: no block given (yield)
  /home/docker/.gem/ruby/2.6.0/bundler/gems/pulsar-client-ruby-f915f9680abd/lib/pulsar/consumer.rb:42:in `listen'
  /home/docker/.gem/ruby/2.6.0/bundler/gems/pulsar-client-ruby-f915f9680abd/lib/pulsar/consumer.rb:48:in `block in listen_in_thread'
```
@lukfugl
allow creation of ConsumerConfiguration from Hash
023b6d3 
including allowing forwarding Hash argument from Client#subscribe
@lukfugl
bump pre-release build number for new gem
3ae951d
@ahuff44 @lukfugl
fix typo (has? -> has_key?)
a9f23fb
@lukfugl
bump build number again
f51abe6 
accidentally built and published .3 without the fix
@ahuff44 @lukfugl
fix consumer_type initializer
bcf9e90
@lukfugl
fix bin/example-*
d14c097 
inverted logic error checking sufficient environment, and a bare `gets`
tries to read from ARGV[0], when present, instead of the intended STDIN
@lukfugl
add reader functionality
e579baa
addisonj
addisonj reviewed Mar 20, 2020
View reviewed changes
README.md
@@ -1 +1,114 @@
# Apache Pulsar Ruby client

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be really useful to put just a broad checklist of the status of this as far as features, for example, let's call out that batch publishing and batch ack don't work yet.

addisonj
addisonj reviewed Mar 20, 2020
View reviewed changes
TODO.md
@@ -0,0 +1,24 @@
# Confirm Licensing and Copyright
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh didn't see this file before. Some of this is specific to us, so we might want to strip it out? If we want to keep this file as the current state of the project, we should point the README at this file

@cristovao-alves-apilio
Copy link

Can this be approved and merged please? 😃

@tc-joegiralt
Copy link

Is this project dead in the water?

@addisonj
Copy link

Hi @tc-joegiralt, no it is not. Instructure has been leading the development and much of the development has happened in their fork here: https://github.com/instructure/pulsar-client-ruby

The goal is to get that all mainlined under apache, but there needs to be work put into the release process under Apache that has blocked this.

That should we should still get the code merged here first and then we can work towards getting the release process in place

@Seitk
Copy link

Seitk commented Mar 10, 2023

Just in case someone is still giving hope on pulsar client ruby, I am developing a forked version on my own and at least working.
https://github.com/Seitk/pulsar-client-ruby

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addisonj addisonj addisonj left review comments

@aahmed-se aahmed-se aahmed-se approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@lukfugl @cristovao-alves-apilio @tc-joegiralt @addisonj @Seitk @aahmed-se @psi @ahuff44