-
Notifications
You must be signed in to change notification settings - Fork 16
2.6.1 beta.2 #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rivernate
wants to merge
65
commits into
apache:master
Choose a base branch
from
instructure:2.6.1-beta.2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
2.6.1 beta.2 #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
can send from a producer and receive and acknowledge from a consumer
so that Producer::send can just take the Message cpp-side also fix service_url handling in bin/example-*
also, switch the using Module#prepend to decorate C++ defined methods with ruby, rather than `_` prefixes
leave the placeholder in the C++ binding code, but don't actually bind it, and don't use it in the example
to see if it makes a difference for where bundler puts the bindings.so file. right now it's putting it in `lib/` instead of in `lib/pulsar/`
and use them in the example producer and consumer
and fix the topic name back to what it had been
still allow passing in the enum value integer directly, but also for convenience translate a set of symbols too and from the enum values
This should fix this error that I ran into when using listen_in_thread: ``` bundler: failed to load command: ./client.rb (./client.rb) LocalJumpError: no block given (yield) /home/docker/.gem/ruby/2.6.0/bundler/gems/pulsar-client-ruby-f915f9680abd/lib/pulsar/consumer.rb:42:in `listen' /home/docker/.gem/ruby/2.6.0/bundler/gems/pulsar-client-ruby-f915f9680abd/lib/pulsar/consumer.rb:48:in `block in listen_in_thread' ```
including allowing forwarding Hash argument from Client#subscribe
accidentally built and published .3 without the fix
inverted logic error checking sufficient environment, and a bare `gets` tries to read from ARGV[0], when present, instead of the intended STDIN
Support partition key and ordering key on top of properties
Adding close call to producer and consumer
- added Gemfile.lock - default rake command also compiles project - installed libpulsar in Travis container
Add CI support to project
Use pulsar 2.6.1 in CI
Add silent_logging option to silence the c++ logger
Update gem version to match pulsar lib version
chore(docs): fixed minor version problem in README
Do live pulsar produce/consume in tests when configured
Allow consumer to subscribe to multiple topics
Add topic getter to message class
add enum values for setting subscription position type
Hi @rivernate thank you for building pulsar ruby client, is this project still on-going? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.