Fix 307 redirect errors when connecting to multi-broker cluster #503
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apurva007
force-pushed
the
redirect_fix
branch
from
ccc829e to
7db7a3b
Compare
|
@tuteng @nodece @rdhabalia Please can you review this change. |
nodece
reviewed
Dec 29, 2022
| }; | ||
| @Override | ||
| protected boolean isRedirectable(final String method) { | ||
| for (final String m: redirectHttpMethods) { |
There was a problem hiding this comment.
I think we can return true directly, don't check the HTTP methods.
There was a problem hiding this comment.
@nodece Thanks for the review. I have made the suggested changes. Please can you review it again.
Apurva007
force-pushed
the
redirect_fix
branch
from
7db7a3b to
1dda980
Compare
nodece
reviewed
Dec 30, 2022
| import org.apache.http.client.methods.HttpGet; | ||
| import org.apache.http.client.methods.HttpHead; | ||
| import org.apache.http.client.methods.HttpPost; | ||
| import org.apache.http.client.methods.HttpPut; |
There was a problem hiding this comment.
@nodece Thanks for pointing it out. Removed the unused imports.
Apurva007
force-pushed
the
redirect_fix
branch
from
1dda980 to
d38460b
Compare
nodece
approved these changes
Dec 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #274
Motivation
This change fixes the invalid redirect errors when the pulsar manager tries to connect to a multi broker cluster.
Modifications
Added a custom redirect strategy in the Http
Client utilized by Zuul. This will make sure that POST/DELETE/PUT methods will also be redirected in addition to the default GET/HEAD methods.
Verifying this change
./gradlew buildchecks.