Cpp support lite#1273
Open
zhaohai666 wants to merge 10 commits into
Open
Conversation
RockteMQ-AI
reviewed
Jun 12, 2026
RockteMQ-AI
left a comment
There was a problem hiding this comment.
Review by github-manager-bot
Summary
Adds "lite push consumer" and "lite producer" support to the C++ client, including new APIs, subscription management, and examples.
Findings
- [Info] This is a large feature PR (2539 additions, 39 files). The changes span CMake/Bazel build configs, new header/source files, examples, and tests.
- [Info]
LitePushConsumer/LitePushConsumerImpl— New consumer type with simplified API. Thread safety annotations (GUARDED_BY,LOCKS_EXCLUDED) are used consistently. - [Info]
LiteSubscriptionManager— Manages subscriptions for lite push consumer. Includes unit tests. - [Info]
thread_annotations_compat.h— Compatibility header for abseil thread safety macros. Good approach for supporting both old and new abseil versions. - [Warning] The PR description is very brief ("Cpp support lite"). Consider adding more detail about:
- What "lite" means in this context (lightweight? simplified API?)
- How it differs from the existing
PushConsumer - Any protocol-level changes or new gRPC methods
- [Warning]
OffsetOption.h— New file. Ensure the offset option semantics are documented and consistent with other language clients. - [Info] Tests —
LiteMessageTest.cppandLiteSubscriptionManagerTest.cppprovide coverage for the new functionality.
Suggestions
- Expand the PR description to explain the "lite" concept and its relationship to existing consumer types.
- Consider adding a README or design doc for the lite push consumer feature.
- Cross-repo: If "lite" is a new protocol feature, ensure the Proxy side (apache/rocketmq) supports it.
Overall: Significant feature addition with good test coverage. The brief description makes it harder to review, but the code quality appears solid.
Automated review by github-manager-bot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cpp support lite push