Skip to content

Cpp support lite#1273

Open
zhaohai666 wants to merge 10 commits into
apache:masterfrom
zhaohai666:feature/cpp-support-lite-push
Open

Cpp support lite#1273
zhaohai666 wants to merge 10 commits into
apache:masterfrom
zhaohai666:feature/cpp-support-lite-push

Conversation

@zhaohai666

Copy link
Copy Markdown
Contributor

Cpp support lite push

@zhaohai666 zhaohai666 changed the title Cpp support lite push Cpp support lite Jun 12, 2026
@zhaohai666 zhaohai666 mentioned this pull request Jun 12, 2026
4 tasks

@RockteMQ-AI RockteMQ-AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review by github-manager-bot

Summary

Adds "lite push consumer" and "lite producer" support to the C++ client, including new APIs, subscription management, and examples.

Findings

  • [Info] This is a large feature PR (2539 additions, 39 files). The changes span CMake/Bazel build configs, new header/source files, examples, and tests.
  • [Info] LitePushConsumer / LitePushConsumerImpl — New consumer type with simplified API. Thread safety annotations (GUARDED_BY, LOCKS_EXCLUDED) are used consistently.
  • [Info] LiteSubscriptionManager — Manages subscriptions for lite push consumer. Includes unit tests.
  • [Info] thread_annotations_compat.h — Compatibility header for abseil thread safety macros. Good approach for supporting both old and new abseil versions.
  • [Warning] The PR description is very brief ("Cpp support lite"). Consider adding more detail about:
    • What "lite" means in this context (lightweight? simplified API?)
    • How it differs from the existing PushConsumer
    • Any protocol-level changes or new gRPC methods
  • [Warning] OffsetOption.h — New file. Ensure the offset option semantics are documented and consistent with other language clients.
  • [Info] Tests — LiteMessageTest.cpp and LiteSubscriptionManagerTest.cpp provide coverage for the new functionality.

Suggestions

  • Expand the PR description to explain the "lite" concept and its relationship to existing consumer types.
  • Consider adding a README or design doc for the lite push consumer feature.
  • Cross-repo: If "lite" is a new protocol feature, ensure the Proxy side (apache/rocketmq) supports it.

Overall: Significant feature addition with good test coverage. The brief description makes it harder to review, but the code quality appears solid.


Automated review by github-manager-bot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants