-
Notifications
You must be signed in to change notification settings - Fork 11.9k
[ISSUE #9439] Add escape for win in the method returning broker configuration #9440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is recommended to perform escaping on the client side (at the admin tools code), and handle it according to the platform type (can be done using MixAll.isWindows).
Thanks for the feedback! I've implemented the client-side escaping in the admin tools code as suggested. The logic now uses |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #9440 +/- ##
=============================================
+ Coverage 48.00% 48.04% +0.03%
- Complexity 11924 11984 +60
=============================================
Files 1307 1308 +1
Lines 92021 92174 +153
Branches 11775 11790 +15
=============================================
+ Hits 44177 44287 +110
- Misses 42368 42386 +18
- Partials 5476 5501 +25 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
934f67f
to
9c0c436
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Which Issue(s) This PR Fixes
Fixes #9439
Brief Description
utilize MixAll.isWindows for platform-specific escaping
Affected files:
MixAll.java
: utilize MixAll.isWindows for platform-specific escapingHow Did You Test This Change?
The above is before the modification, you can see the bug. The following is after the modification, you can see the program returns normally.