[#ISSUE 1005] - Expand checkstyle to all modules (root)

[damonxue]

fixes #1005

If your pull request is about ~20 lines of code you don't need to sign an Individual Contributor License Agreement
I had signed an [Individual Contributor License Agreement] in Apache ShenYu project.

[lprimak]

there are still compiler errors :(

[lprimak]

yea... the code needs to compile has nothing to do with checkstyle. Also owasp is only secure checks, not the code style etc.

[damonxue]

yea... the code needs to compile has nothing to do with checkstyle. Also owasp is only secure checks, not the code style etc.

It's my fault, i did not see the build plugins. And did the compile error cause by the property of root.dir?

[lprimak]

No problem. The point of this issue is to fix Shiro code so it complies with the checkstyle rules and passes.

No, root.dir doesn't cause any issues.

[lprimak]

I ran into some backlog in my day job. Please be patient.

[lprimak]

First of all, great job, thanks!
I have fixed up the configuration for the most part to the way it was.

However, some major and minor issues remain
Some minor issues:

• Line endings. Looks like you have windows line endings in your source code. This repo uses unix line endings. Can you fix that?

Major issues:

• Tests and demos need to be included in checkstyle checking
• There are too many changes in checkstyle configuration. Most things should be done inline using @SuppressWarnings and not in configuration

[lprimak]

I have started the process to fix code with the new config. Ready for you to take over and finish it. The things I did should get you started.

Thank you once again, great job!

[lprimak]

The only configuration that should be modified now is by adding more JavadocPackages in suppressins.xml
Everything else should be made inline unless I missed something egregious

[damonxue]

Ok, i see. I will done the unfinished.

[damonxue]

@lprimak @bmarwell pls review.

[lprimak]

You are doing a way too much...

• Only code that fails checkstyle should be reformatted, no more no less.
• Line length should not be ignored / suppressed, but fixed. Looks like you added many suppressions for that. There should be none.

Once again I appreciate your effort, great job!
I believe this is gettin closer!

[damonxue]

• The reason for formatting too many files is to make sure that they all end with 'lf'.
• I will change too many 'lineLength'.

[damonxue]

to #1069