bugfix(tests): using JUnit's ResourceLock annotation for tests that touch…#1467
Merged
lprimak merged 1 commit intoapache:mainfrom May 25, 2024
Merged
bugfix(tests): using JUnit's ResourceLock annotation for tests that touch…#1467lprimak merged 1 commit intoapache:mainfrom
lprimak merged 1 commit intoapache:mainfrom
Conversation
lprimak
force-pushed
the
parallel-core-tests
branch
3 times, most recently
from
a921137 to
8ac9f96
Compare
lprimak
changed the title
lprimak
force-pushed
the
parallel-core-tests
branch
from
8ac9f96 to
a1767f7
Compare
bmarwell
requested changes
May 14, 2024
lprimak
force-pushed
the
parallel-core-tests
branch
4 times, most recently
from
d4d0d63 to
8026a24
Compare
bmarwell
previously requested changes
May 14, 2024
lprimak
force-pushed
the
parallel-core-tests
branch
from
8026a24 to
13f6c68
Compare
bmarwell
previously requested changes
May 16, 2024
lprimak
force-pushed
the
parallel-core-tests
branch
from
21b382c to
bbd8e1f
Compare
lprimak
force-pushed
the
parallel-core-tests
branch
from
bbd8e1f to
b90de29
Compare
10 tasks
bdemers
reviewed
May 24, 2024
Member
bdemers
left a comment
bdemers
left a comment
There was a problem hiding this comment.
+0.9
This is great!
I left a few comments about adding adding a value to the Isolated annotation. suggestions are in there too, but they were added via the GH UI...
This is a non-blocking review 😉
config/ogdl/src/test/groovy/org/apache/shiro/config/ogdl/CommonsInterpolatorTest.groovy
Outdated
Show resolved
Hide resolved
| /** | ||
| * Unit tests for the {@link org.apache.shiro.config.ogdl.ReflectionBuilder} implementation. | ||
| */ | ||
| @Isolated |
Member
There was a problem hiding this comment.
nit: add reason for needing to be isolated (we can possibly fix it in the future)
Contributor
Author
There was a problem hiding this comment.
haha Dunno.. cause it failed :)
| * | ||
| * @since 1.2 | ||
| */ | ||
| @Isolated |
| /** | ||
| * @since 0.1 | ||
| */ | ||
| @Isolated |
| * | ||
| * @since May 11, 2010 12:41:38 PM | ||
| */ | ||
| @Isolated |
| * | ||
| * @since 1.2 | ||
| */ | ||
| @Isolated |
Member
There was a problem hiding this comment.
nit: add reason
My guess is that the INI / reflection builder might be sys prop related?
web/src/test/groovy/org/apache/shiro/web/filter/InvalidRequestFilterTest.groovy
Outdated
Show resolved
Hide resolved
web/src/test/groovy/org/apache/shiro/web/servlet/AbstractShiroFilterTest.groovy
Outdated
Show resolved
Hide resolved
web/src/test/groovy/org/apache/shiro/web/util/WebUtilsTest.groovy
Outdated
Show resolved
Hide resolved
| /** | ||
| * @since 0.9 | ||
| */ | ||
| @Isolated |
bmarwell
approved these changes
May 24, 2024
… make parallel tests work
lprimak
force-pushed
the
parallel-core-tests
branch
from
7524f38 to
5c749d4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… global SecurityManager
Following this checklist to help us incorporate your contribution quickly and easily:
for the change (usually before you start working on it). Trivial changes like typos do not
require a GitHub issue. Your pull request should address just this issue, without pulling in other changes.
[#XXX] - Fixes bug in SessionManager,where you replace
#XXXwith the appropriate GitHub issue. Best practiceis to use the GitHub issue title in the pull request title and in the first line of the commit message.
fixes #XXXif merging the PR should close a related issue.mvn verifyto make sure basic checks pass. A more thorough check will be performed on your pull request automatically.git rebase -i.Trivial changes like typos do not require a GitHub issue (javadoc, comments...).
In this case, just format the pull request title like
[DOC] - Add javadoc in SessionManager.If this is your first contribution, you have to read the Contribution Guidelines
If your pull request is about ~20 lines of code you don't need to sign an Individual Contributor License Agreement
if you are unsure please ask on the developers list.
To make clear that you license your contribution under the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.