Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -149,12 +149,12 @@ void checkCallWhenAuth() {
@Test
@OperateOnDeployment(DEPLOYMENT_DEV_MODE)
void beanDestroyCalled() {
exersizeViewAndSessionScoped(facesViewScoped, "api/statistics/pc_fv", "api/statistics/pd_fv", !isJakarta());
exerciseViewAndSessionScoped(facesViewScoped, "api/statistics/pc_fv", "api/statistics/pd_fv", !isJakarta());
webDriver.get(baseURL + "api/statistics/clear");
exersizeViewAndSessionScoped(omniViewScoped, "api/statistics/pc_ofv", "api/statistics/pd_ofv", false);
exerciseViewAndSessionScoped(omniViewScoped, "api/statistics/pc_ofv", "api/statistics/pd_ofv", false);
}

private void exersizeViewAndSessionScoped(WebElement elem, String createStatistic, String destroyStatistic,
private void exerciseViewAndSessionScoped(WebElement elem, String createStatistic, String destroyStatistic,
boolean isBrokenDestructor) {
webDriver.get(baseURL + "shiro/auth/loginform");
login();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,7 @@ public interface FilterChainManager {
* Configures the set of named filters that will match all paths. These filters will match BEFORE explicitly
* configured filter chains i.e. by calling {@link #createChain(String, String)}, {@link #addToChain(String, String)}, etc.
* <br>
* <strong>Filters configured in this list wll apply to ALL requests.</strong>
* <strong>Filters configured in this list will apply to ALL requests.</strong>
*
* @param globalFilterNames the list of filter names to match ALL paths.
* @throws ConfigurationException if one of the filter names is invalid and cannot be loaded from the set of
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ public Subject createSubject(SubjectContext context) {
//SHIRO-646
//Check if the existing subject is NOT a WebSubject. If it isn't, then call super.createSubject instead.
//Creating a WebSubject from a non-web Subject will cause the ServletRequest and ServletResponse to be null,
// which wil fail when creating a session.
// which will fail when creating a session.
boolean isNotBasedOnWebSubject = context.getSubject() != null && !(context.getSubject() instanceof WebSubject);
if (!(context instanceof WebSubjectContext) || isNotBasedOnWebSubject) {
return super.createSubject(context);
Expand Down