[SHIRO-770] Remove base64 implementation, keep UTF-8 codec by default.#224
[SHIRO-770] Remove base64 implementation, keep UTF-8 codec by default.#224fpapon merged 1 commit intoapache:masterfrom bmarwell:base64-away2
Conversation
|
Build is broken because of jacip maven plugin for api incompatibility but it's normal as we move on 2.0.0 and we want to broke this. |
+1, the config probably needs to change as a major version change in the pom should allow for breaking API changes. Once we get closer to a beta for date for 2.x, we can generate a japicmp report and list out the API changes. |
|
@bmhm great change! PRs that remove code are my favorite 😄 |
|
retest this please |
|
@bmhm can you create a Jira for this issue? |
|
For v2.0.0, we probably do not want to maintain our own Base64 implementation.
Still, the shiro implementation defaulted to UTF-8 for decoding strings, which seems to be a sane default.
However, the
CryptoExceptionbecame unreachable from the Base64 class. As this is not cryptography anyway, I decided to replace it with theIllegalArgumentExceptionthrown byjava.util.Base64's methods.