[SHIRO-773] update groovy for JDK14 builds.#231
Merged
fpapon merged 1 commit intoapache:masterfrom May 9, 2020
bmarwell:SHIRO-773-groovy
Merged
[SHIRO-773] update groovy for JDK14 builds.#231fpapon merged 1 commit intoapache:masterfrom bmarwell:SHIRO-773-groovy
fpapon merged 1 commit intoapache:masterfrom
bmarwell:SHIRO-773-groovy
Conversation
Contributor
bmarwell
commented
May 9, 2020
bmarwell
commented
- Updated groovy to 3.x. 2.5.10 would have been enough, but here were no failing tests due to the use of the new major version, so why not just update?
- Added an oversight from SHIRO-736 where it was found out that the GCM padding cipher is just an alias for the non-padding one. It was only added for block mode ciphers. This is needed to get Shiro compiling with JDK14.
bdemers
added a commit
that referenced
this pull request
May 4, 2021
Update groovy version (uses an ASM version that supports java 14) Pre Java 14 "AES/GCM/PKCS5Padding" was basically an alias to "AES/GCM/NoPadding" this is no longer the case https://www.oracle.com/java/technologies/javase/14-relnote-issues.html#JDK-8180392 back-port: #231
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.