[SHIRO-778] onInit method on AuthenticatingRealm is called twice

[fpapon]

No description provided.

[fpapon]

@bdemers I made some polish, I think it's better now.

[bmarwell]

Just a little detail left if you don't mind

[bdemers]

Looks good,! it would be great to have a test for this one. (possibly just tweaking the existing test InitializableBean to count the number of times init() was called)

[bmarwell]

Looks good,! it would be great to have a test for this one. (possibly just tweaking the existing test InitializableBean to count the number of times init() was called)

Or just create a mock objects and see if values() was called using an appropriate verify() method. This way you would not need to change production code for tests.

[bmarwell]

one testcase missing, see description. It is similar to my previous one, but in mine, null was called after the defined objects, whereas we should have a "correct" test case where we call the method with null first (which is what actually happens in shiro).

[bmarwell]

LGTM 👍
@bdemers WDYT?