[SHIRO-789] Add SameSite option to AbstractShiroWebConfiguration.buildCookie#251
Merged
bdemers merged 1 commit intoapache:masterfrom Oct 17, 2020
bmarwell:SHIRO-789
Merged
[SHIRO-789] Add SameSite option to AbstractShiroWebConfiguration.buildCookie#251bdemers merged 1 commit intoapache:masterfrom bmarwell:SHIRO-789
bdemers merged 1 commit intoapache:masterfrom
bmarwell:SHIRO-789
Conversation
bdemers
reviewed
Aug 20, 2020
...t/spring/src/main/java/org/apache/shiro/spring/web/config/AbstractShiroWebConfiguration.java
Outdated
Show resolved
Hide resolved
bdemers
reviewed
Aug 20, 2020
Member
bdemers
left a comment
There was a problem hiding this comment.
Looks good! one minor comment about the signature change
Contributor
Author
|
retest this please |
…dCookie Functional changes: - automatically set secure cookie on SameSiteOptions.NONE - added test for the default value = LAX - added test class for STRICT value Other changes: - add javadoc cookie description from developer.mozilla.org - add missing overrides - remove unused imports in AbstractShiroWebConfiguration and its test
Member
|
(rebased on master) |
Member
|
retest this please |
bdemers
approved these changes
Oct 17, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Functional changes:
Other changes:
Following this checklist to help us incorporate your contribution quickly and easily:
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
[SHIRO-XXX] - Fixes bug in SessionManager,where you replace
SHIRO-XXXwith the appropriate JIRA issue. Best practiceis to use the JIRA issue title in the pull request title and in the first line of the commit message.
mvn clean install apache-rat:checkto make sure basic checks pass. A more thorough check will be performed on your pull request automatically.git rebase -i.Trivial changes like typos do not require a JIRA issue (javadoc, comments...).
In this case, just format the pull request title like
(DOC) - Add javadoc in SessionManager.If this is your first contribution, you have to read the Contribution Guidelines
If your pull request is about ~20 lines of code you don't need to sign an Individual Contributor License Agreement
if you are unsure please ask on the developers list.
To make clear that you license your contribution under the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.