Skip to content

Fix next SWIP ID#12217

Merged
wu-sheng merged 1 commit intomasterfrom
wu-sheng-patch-1
May 13, 2024
Merged

Fix next SWIP ID#12217
wu-sheng merged 1 commit intomasterfrom
wu-sheng-patch-1

Conversation

@wu-sheng
Copy link
Member

@wu-sheng wu-sheng commented May 13, 2024

  • If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #.
  • Update the CHANGES log.

FYI @CzyerChen You seem to miss this in your last SWIP.

@wu-sheng wu-sheng added documentation Provide documents related issue or pull request only. chore Chores about the project, like code cleaning up, typos, upgrading dependencies, etc. labels May 13, 2024
@wu-sheng wu-sheng added this to the 10.1.0 milestone May 13, 2024
@wu-sheng wu-sheng requested a review from wankai123 May 13, 2024 08:01
@wu-sheng wu-sheng merged commit 7f20b99 into master May 13, 2024
@wu-sheng wu-sheng deleted the wu-sheng-patch-1 branch May 13, 2024 08:04
@wu-sheng wu-sheng modified the milestones: 10.1.0, 10.0.1 May 29, 2024
ffaa3dd added a commit to ffaa3dd/skywalking that referenced this pull request Jun 9, 2024
@ffaa3dd
Revert "Fix next SWIP ID (apache#12217)"
cd02021 
This reverts commit 7f20b99.
@CodePrometheus
Copy link
Contributor

CodePrometheus commented Sep 20, 2024

There may be is a small typo here. The current SWIP-8 should be SWIP-6. The next SWIP number is right for now, let me rename the filename.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wankai123 wankai123 wankai123 approved these changes

Assignees

No one assigned

Labels

chore Chores about the project, like code cleaning up, typos, upgrading dependencies, etc. documentation Provide documents related issue or pull request only.

Projects

None yet

Milestone

10.0.1

Development

Successfully merging this pull request may close these issues.

3 participants

@wu-sheng @CodePrometheus @wankai123