[SPARK-51883][DOCS][PYTHON] Python Data Source user guide for filter pushdown #50684
+194
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wengh
changed the title
|
|
||
| Other methods such as DataSource.schema() and DataSourceStreamReader.latestOffset() can be stateful. Changes to the object state made in these methods are visible to future invocations. | ||
|
|
||
| Refer to the documentation of each method for more details. |
There was a problem hiding this comment.
Can we also link to the documentation here?
| from pyspark.sql.datasource import EqualTo, Filter, GreaterThan, LessThan | ||
| def pushFilters(self, filters: List[Filter]) -> Iterable[Filter]: |
There was a problem hiding this comment.
Can we add a complete example here so that people can copy paste and try it out?
There was a problem hiding this comment.
Changed to an example source that returns prime numbers sequentially
python/pyspark/sql/datasource.py
Outdated
Comment on lines
544
to
545
| Configuration `spark.sql.python.filterPushdown.enabled` must be set to `true` | ||
| to implement this method. |
There was a problem hiding this comment.
Not sure if we should put this in the doc. Can we throw an warning in the code?
There was a problem hiding this comment.
Yeah, we already show an error if it's disabled. I guess the user can find out when they try to use the source so it's not necessary to put in the doc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Update
python_data_source.rstto add filter pushdown docs.Why are the changes needed?
Feature was added but documentation was still missing.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Verified locally
Was this patch authored or co-authored using generative AI tooling?
Yes. Initial draft was generated using AI then manually edited.
Generated-by: GitHub Copilot with Claude 3.7 Sonnet