[SPARK-50762][SQL][TEST][FOLLOWUP][4.0] Regenerate sql-udf.sql.out
#50928
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @allisonwang-db and @cloud-fan |
|
Could you review this test PR for branch-4.0, @peter-toth ? |
|
Could you review this PR too, @viirya ? |
viirya
approved these changes
May 17, 2025
|
Thank you, @viirya ! |
HyukjinKwon
approved these changes
May 17, 2025
dongjoon-hyun
added a commit
that referenced
this pull request
May 17, 2025
### What changes were proposed in this pull request? This is a follow-up of #50898 for branch-4.0. - #50898 ### Why are the changes needed? #50898 broke `branch-4.0` CIs. - https://github.com/apache/spark/actions/runs/15070364465/job/42364916342 - https://github.com/apache/spark/actions/runs/15070303045/job/42364700177 - https://github.com/apache/spark/actions/runs/15070364465/job/42364916342 ``` - sql-udf.sql_analyzer_test *** FAILED *** sql-udf.sql_analyzer_test Expected "...g.default.foo3_1b(c2[))#xL > cast(0 as bigint)) +- Project [c1#x, count(1)#xL, spark_catalog.default.foo3_1b(x#x) AS spark_catalog.default.foo3_1b(sum(c2))#x, sum(spark_catalog.default.foo3_1b(c2))#xL] +- Project [c1#x, count(1)#xL, sum(c2)#xL, sum(spark_catalog.default.foo3_1b(c2))#xL, cast(sum(c2)#xL as int) AS x#x] +- Aggregate [c1#x], [c1#x, count(1) AS count(1)#xL, sum(c2#x) AS sum(c2)#xL, sum(spark_catalog.default.foo3_1b(x#x)) AS sum(spark_catalog.default.foo3_1b(c2]))#xL] +...", but got "...g.default.foo3_1b(c2[#x))#xL > cast(0 as bigint)) +- Project [c1#x, count(1)#xL, spark_catalog.default.foo3_1b(x#x) AS spark_catalog.default.foo3_1b(sum(c2))#x, sum(spark_catalog.default.foo3_1b(c2#x))#xL] +- Project [c1#x, count(1)#xL, sum(c2)#xL, sum(spark_catalog.default.foo3_1b(c2#x))#xL, cast(sum(c2)#xL as int) AS x#x] +- Aggregate [c1#x], [c1#x, count(1) AS count(1)#xL, sum(c2#x) AS sum(c2)#xL, sum(spark_catalog.default.foo3_1b(x#x)) AS sum(spark_catalog.default.foo3_1b(c2#x]))#xL] +..." Result did not match for query #152 SELECT c1, COUNT(*), foo3_1b(SUM(c2)) FROM t1 GROUP BY c1 HAVING SUM(foo3_1b(c2)) > 0 (SQLQueryTestSuite.scala:683) ``` ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #50928 from dongjoon-hyun/SPARK-50762. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
|
Thank you, @HyukjinKwon . Merged to branch-4.0. |
|
thanks for the fix! |
|
Thanks for the fix! |
|
Thank you, @cloud-fan , @peter-toth , @allisonwang-db . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is a follow-up of #50898 for branch-4.0.
Why are the changes needed?
#50898 broke
branch-4.0CIs.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass the CIs.
Was this patch authored or co-authored using generative AI tooling?
No.