-
Notifications
You must be signed in to change notification settings - Fork 29k
Increase report interval of spaming logs to 10 seconds #51012
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase report interval of spaming logs to 10 seconds #51012
Conversation
|
I have enabled the actions in my fork, but I can't rerun the failed job, please help. |
|
Someone please respond on this? |
|
Someone please maybe help me? |
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that there is no silver bullet for all heterogeneous environments, I don't think the change of default values can give us a solution for all.
I'd like to recommend you to apply the proper configuration in your environments (via Airflow) instead of affecting all world-wide community, @Avihais12344 .
Yes, we have done it. But I still think that printing that log message every |
|
It's your opinion which (at least) I disagree with you. In general, there is no way to build a consensus on this for this kind of issue.
|
If the talk is about opinions, there is no much I can do. As I still disagree with you. |
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to the above discussion result, I cast a veto to this PR in order to prevent accidental merging.
What does it means exactly (I am pretty new to open source)? |
|
You can read more here @Avihais12344 |
|
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. |
What changes were proposed in this pull request?
In this PR I want to increase the default report interval of both
K8SandApache Yarnfrom
1sto10s.Why are the changes needed?
Due to the logs of type:
Being printed for every 1 seconds, the amount of logs made our
Airflow's UI slow,it also takes too much space as we save the spark logs for future use.
I think the report interval should be increased to make a better balance between notifying the user
that the application is running and not spamming us.
I think it should be done globally to prevent other users to go what we went through:
If we would update the default, we would ease the use for many users in my opinion.
Does this PR introduce any user-facing change?
Yes, in this PR we increase the report interval from 1 second to 10 seconds.
The log of type:
Would be printed every 10 seconds and not every 1 second by default.
But the users can change it if they want to, and they shouldn't be affected by it as it's just logging.
How was this patch tested?
I have tesed the patch manually,
I have an
AirflowCluster with docker, a k8s cluster. With that, I have created a spark submit connection,and created a DAG that uses the spark submit operator
to run spark on my k8s.
The important thing that I have done is that I have added the config:
{ "spark.kubernetes.report.interval": "10s" }To my spark application at the spark submit operator conf.
Which made the report interval to increase to 10 seconds from 1 second.
Was this patch authored or co-authored using generative AI tooling?
No.
This is my first PR, if there's a problem, please notify me.