[SPARK-52489][SQL] Forbid duplicate SQLEXCEPTION and NOT FOUND handlers inside SQL Script #51168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Adding @cloud-fan , @davidm-db, @MaxGekk |
sql/core/src/main/scala/org/apache/spark/sql/scripting/SqlScriptingInterpreter.scala
Show resolved
Hide resolved
dusantism-db
approved these changes
Jun 12, 2025
cloud-fan
approved these changes
Jun 13, 2025
|
|
davidm-db
approved these changes
Jun 13, 2025
|
Let's create a JIRA ticket. This is not a minor change. Otherwise LGTM |
miland-db
changed the title
|
Hey @cloud-fan, I created a JIRA ticket. Thanks for the review! |
|
thanks, merging to master/4.0! |
cloud-fan
pushed a commit
that referenced
this pull request
Jun 19, 2025
…rs inside SQL Script
### What changes were proposed in this pull request?
In this PR we forbid duplicate SQLEXCEPTION or NOT FOUND exception handlers to be defined in the same scope. This was already done for different conditions and sqlstates but was not done for these 2 types of exception handlers. Code like this should fail:
```
BEGIN
DECLARE EXIT HANDLER FOR NOT FOUND
BEGIN
SELECT 1;
END;
DECLARE EXIT HANDLER FOR NOT FOUND
BEGIN
SELECT 2;
END;
END
```
### Why are the changes needed?
This is a bug fix.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
New tests in `SqlScriptingInterpreterSuite`.
### Was this patch authored or co-authored using generative AI tooling?
No.
Closes #51168 from miland-db/milan-dankovic_data/forbid-duplicate-handlers.
Authored-by: Milan Dankovic <[email protected]>
Signed-off-by: Wenchen Fan <[email protected]>
(cherry picked from commit 23cf926)
Signed-off-by: Wenchen Fan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In this PR we forbid duplicate SQLEXCEPTION or NOT FOUND exception handlers to be defined in the same scope. This was already done for different conditions and sqlstates but was not done for these 2 types of exception handlers. Code like this should fail:
Why are the changes needed?
This is a bug fix.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
New tests in
SqlScriptingInterpreterSuite.Was this patch authored or co-authored using generative AI tooling?
No.