Skip to content

Conversation

Vitor-Avila
Copy link
Contributor

SUMMARY

#29187 introduced a new API endpoint to process the dashboard PDF / PNG download. Since the Download > menu options can be exposed in Embedded, then this new endpoint must accept requests without a CSRF token.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

No UI changes.

TESTING INSTRUCTIONS

  1. Launch a dashboard in embedded mode (make sure that chartControls are visible).
  2. Trigger a dashboard download.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@dosubot dosubot bot added api Related to the REST API embedded labels Aug 15, 2024
Copy link

codecov bot commented Aug 15, 2024

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.70%. Comparing base (76d897e) to head (bb922ad).
⚠️ Report is 2419 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #29953       +/-   ##
===========================================
+ Coverage   60.48%   83.70%   +23.21%     
===========================================
  Files        1931      527     -1404     
  Lines       76236    38069    -38167     
  Branches     8568        0     -8568     
===========================================
- Hits        46114    31866    -14248     
+ Misses      28017     6203    -21814     
+ Partials     2105        0     -2105     
Flag Coverage Δ
hive 49.01% <ø> (-0.14%) ⬇️
javascript ?
mysql 76.78% <ø> (?)
postgres 76.86% <ø> (?)
presto 53.56% <ø> (-0.25%) ⬇️
python 83.70% <ø> (+20.20%) ⬆️
sqlite 76.34% <ø> (?)
unit 60.36% <ø> (+2.73%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sadpandajoe sadpandajoe added the v4.1 Label added by the release manager to track PRs to be included in the 4.1 branch label Aug 15, 2024
@Vitor-Avila Vitor-Avila merged commit 47715c3 into apache:master Aug 15, 2024
40 of 41 checks passed
sadpandajoe pushed a commit that referenced this pull request Aug 16, 2024
@github-actions github-actions bot added 🍒 4.1.0 Cherry-picked to 4.1.0 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels labels Nov 14, 2024
@mistercrunch mistercrunch added the 🍒 4.1.1 Cherry-picked to 4.1.1 label Nov 27, 2024
@github-actions github-actions bot added the 🍒 4.1.2 Cherry-picked to 4.1.2 label Apr 1, 2025
@mistercrunch mistercrunch added 🍒 4.1.3 Cherry-picked to 4.1.3 🚢 5.0.0 First shipped in 5.0.0 labels Jul 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Related to the REST API 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels embedded size/XS v4.1 Label added by the release manager to track PRs to be included in the 4.1 branch 🍒 4.1.0 Cherry-picked to 4.1.0 🍒 4.1.1 Cherry-picked to 4.1.1 🍒 4.1.2 Cherry-picked to 4.1.2 🍒 4.1.3 Cherry-picked to 4.1.3 🍒 4.1.4 🚢 5.0.0 First shipped in 5.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants