feat(helm): Allow multi-database connection support

[tadeha]

SUMMARY

This feature introduces dynamic database connection support for Superset Helm Chart, allowing users to select between different database types like PostgreSQL (default) and MySQL. Previously, the SQLALCHEMY_DATABASE_URI was hardcoded to postgresql+psycopg2. This enhancement enables the database backend to be configured directly through values.yaml.

The supersetNode.connections.db_type option controls which database type Superset will connect to.

This change is fully backward compatible:

If supersetNode.connections.db_type is not explicitly set in values.yaml (as would be the case for existing deployments), it defaults to "postgresql", preserving current functionality.

Validation is included to prevent unsupported database_type values from being deployed.

TESTING INSTRUCTIONS

1. To test PostgreSQL (Default Behavior):

   • Ensure supersetNode.connections.db_type is either commented out or set to "postgresql" in values.yaml.
   • Install/Upgrade Helm chart: helm upgrade --install superset .
   • Verify Superset successfully connects to PostgreSQL.

2. To test MySQL:

   • Prepare your Superset Image: Build a custom Superset Docker image that includes the mysqlclient Python package (e.g., by adding RUN pip install mysqlclient after installing build dependencies like default-libmysqlclient-dev). Update your values.yaml to use this new image.
   • In values.yaml, set supersetNode.connections.db_type: "mysql".
   • Configure your MySQL connection details:
     • Set supersetNode.connections.db_host to your MySQL server's host.
     • Set supersetNode.connections.db_user, db_pass, db_name, db_port for your MySQL database.
   • Install/Upgrade Helm chart: helm upgrade --install superset .
   • Verify Superset successfully connects to MySQL.

3. To test Validation (Unsupported Type):

   • In values.yaml, set supersetNode.connections.db_type: "unsupported_db_type".
   • Attempt to install/upgrade Helm chart: helm upgrade --install superset .
   • Verify that the Helm command fails with an error message indicating an unsupported database_type.

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[korbit-ai]

I've completed my review and didn't find any issues.

Check out our docs on how you can make Korbit work best for you and your team.

Loving Korbit!? Share us on LinkedIn Reddit and X

[github-actions]

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️

We hope to see you in our Slack community too! Not signed up? Use our Slack App to self-register.

[tadeha]

Can we have one more look, please? @rusackas @betodealmeida

[rusackas]

Pinged @betodealmeida on Slack about this, but it looks like the PR is also in need of a rebase, if you don't mind brushing it up a little :D

[tadeha]

Pinged @betodealmeida on Slack about this, but it looks like the PR is also in need of a rebase, if you don't mind brushing it up a little :D

Sure. Thank you, and Done.

[tadeha]

Hey there, do we have an update on this? @rusackas