feat(database): Adding per-user caching option in Security tab #34842
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Based on your review schedule, I'll hold off on reviewing this PR until it's marked as ready for review. If you'd like me to take a look now, comment
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #34842 +/- ##
===========================================
+ Coverage 0 71.91% +71.91%
===========================================
Files 0 587 +587
Lines 0 43464 +43464
Branches 0 4698 +4698
===========================================
+ Hits 0 31259 +31259
- Misses 0 10978 +10978
- Partials 0 1227 +1227
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…andrusoare/feat/cache-per-user
dosubot
bot
added
change:frontend
![korbit-ai[bot]](https://avatars.githubusercontent.com/in/322216?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review by Korbit AI
Korbit automatically attempts to detect when you fix issues in new commits.
| Category | Issue | Status |
|---|---|---|
 |
Repeated JSON parsing in cache_key method ▹ view | 🧠 Not in scope |
Files scanned
| File Path | Reviewed |
|---|---|
| superset-frontend/src/features/databases/types.ts | ✅ |
| superset/common/query_object.py | ✅ |
| superset-frontend/src/features/databases/DatabaseModal/ExtraOptions.tsx | ✅ |
| superset/databases/schemas.py | ✅ |
Explore our documentation to understand the languages and file types we support and the files we ignore.
Check out our docs on how you can make Korbit work best for you and your team.
| # the database | ||
| try: | ||
| database = self.datasource.database # type: ignore | ||
| extra = json.loads(database.extra or "{}") |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
msyavuz
reviewed
Sep 16, 2025
msyavuz
added
the
🎪 ⚡ showtime-trigger-start
github-actions
bot
added
🎪 e5fd71c 🚦 building
github-actions
bot
added
🎪 e5fd71c 🚦 deploying
|
🎪 Showtime deployed environment on GHA for e5fd71c • Environment: http://34.220.167.212:8080 (admin/admin) |
…andrusoare/feat/cache-per-user
mistercrunch
added
the
🎪 🎯 e5fd71c
github-actions
bot
added
🎪 3f98bce 🚦 building
github-actions
bot
added
🎪 3f98bce 🚦 deploying
|
🎪 Showtime deployed environment on GHA for 3f98bce • Environment: http://54.190.191.133:8080 (admin/admin) |
…andrusoare/feat/cache-per-user
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
per_user_cachingflag at the database levelCACHE_QUERY_BY_USERBEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
BEFORE
AFTER
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION