Skip to content

feat(matrixify): replace single toggle with separate horizontal/vertical layout controls #35067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Sep 17, 2025
Merged

feat(matrixify): replace single toggle with separate horizontal/vertical layout controls #35067

merged 19 commits into from
Sep 17, 2025
+493 −231

Conversation

mistercrunch
Copy link
Member

@mistercrunch mistercrunch commented Sep 9, 2025 •
edited
Loading

building upon #34526, here I'm replacing the single "Enable Matrixify" checkbox with two separate controls for better clarity:

  • "Enable vertical layout (rows)" - for creating matrix rows
  • "Enable horizontal layout (columns)" - for creating matrix columns

This provides clearer user guidance about what each layout type does and allows independent control of row vs column matrix layouts.

Key changes:

  • Split matrixify_enabled into matrixify_enable_vertical_layout and matrixify_enable_horizontal_layout
  • Updated all references across components to use new layout controls
  • Improved control panel organization with progressive disclosure
  • Enhanced visibility logic to show relevant controls based on layout selection
  • Added utility functions for checking layout states
  • Removed problematic validators that were blocking form rendering
  • Enabled MATRIXIFY feature flag for testing

mistercrunch and others added 2 commits September 8, 2025 22:44
@mistercrunch @claude
Standardize webpack dev server host configuration and enable LAN access
7c3931d 
- Adds configurable devserverHost parameter with CLI and env var support
- Supports WEBPACK_DEVSERVER_HOST and WEBPACK_DEVSERVER_PORT environment variables
- Maintains CLI argument precedence: --devserverHost > WEBPACK_DEVSERVER_HOST > 127.0.0.1
- Updates allowedHosts to support .local domains for LAN development
- Removes docker-compose localhost binding restriction for external access
- Follows 2025 framework standards: secure by default, easy opt-in for network access

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>
@mistercrunch @claude
feat(matrixify): replace single toggle with separate horizontal/verti…
d3bf6a2 
…cal layout controls

Replace the single "Enable Matrixify" checkbox with two separate controls for better clarity:
- "Enable vertical layout (rows)" - for creating matrix rows
- "Enable horizontal layout (columns)" - for creating matrix columns

This provides clearer user guidance about what each layout type does and allows
independent control of row vs column matrix layouts.

Key changes:
- Split matrixify_enabled into matrixify_enable_vertical_layout and matrixify_enable_horizontal_layout
- Updated all references across components to use new layout controls
- Improved control panel organization with progressive disclosure
- Enhanced visibility logic to show relevant controls based on layout selection
- Added utility functions for checking layout states
- Removed problematic validators that were blocking form rendering
- Enabled MATRIXIFY feature flag for testing

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>
@dosubot dosubot bot added the change:frontend Requires changing the frontend label Sep 9, 2025
korbit-ai[bot]
korbit-ai bot reviewed Sep 9, 2025
View reviewed changes
Copy link

@korbit-ai korbit-ai bot left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review by Korbit AI

Korbit automatically attempts to detect when you fix issues in new commits.
Category Issue Status
Security Over-permissive development server host access ▹ view ✅ Fix detected
Files scanned ​
File Path Reviewed
superset-frontend/src/utils/matrixifyUtils.ts ✅
superset-frontend/src/explore/controlUtils/getSectionsToRender.ts ✅
superset-frontend/packages/superset-ui-chart-controls/src/sections/matrixify.tsx ✅
superset-frontend/src/components/Chart/DrillBy/DrillByMenuItems.tsx ✅
superset-frontend/packages/superset-ui-core/src/chart/types/matrixify.ts ✅
superset-frontend/src/explore/controlPanels/sections.tsx ✅
superset-frontend/src/components/Chart/ChartContextMenu/ChartContextMenu.tsx ✅
superset-frontend/src/components/Chart/ChartRenderer.jsx ✅
superset-frontend/src/explore/components/ExploreChartPanel/index.tsx ✅
superset-frontend/packages/superset-ui-chart-controls/src/shared-controls/matrixifyControls.tsx ✅
superset-frontend/webpack.config.js ✅
superset/config.py ✅

Explore our documentation to understand the languages and file types we support and the files we ignore.

Check out our docs on how you can make Korbit work best for you and your team.

Loving Korbit!? Share us on LinkedIn Reddit and X

superset-frontend/webpack.config.js
hot: true,
host: devserverHost,
port: devserverPort,
allowedHosts: ['localhost', '.localhost', '127.0.0.1', '::1', '.local'],

This comment was marked as resolved.

Sign in to view

@mistercrunch mistercrunch added the 🎪 ⚡ showtime-trigger-start Create new ephemeral environment for this PR label Sep 9, 2025
@github-actions github-actions bot added 🎪 8fffed7 🚦 building Environment 8fffed7 status: building 🎪 8fffed7 📅 2025-09-09T16-20 Environment 8fffed7 created at 2025-09-09T16-20 🎪 8fffed7 ⌛ 24h Environment 8fffed7 expires after 24h and removed 🎪 ⚡ showtime-trigger-start Create new ephemeral environment for this PR labels Sep 9, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 9, 2025

🎪 Showtime is building environment on GHA for 8fffed7

@github-actions github-actions bot added 🎪 8fffed7 🤡 mistercrunch Environment 8fffed7 requested by mistercrunch 🎪 8fffed7 🚦 deploying Environment 8fffed7 status: deploying 🎪 8fffed7 🚦 running Environment 8fffed7 status: running 🎪 🎯 8fffed7 Active environment pointer - 8fffed7 is receiving traffic 🎪 8fffed7 🌐 54.190.0.29:8080 Environment 8fffed7 URL: http://54.190.0.29:8080 (click to visit) and removed 🎪 8fffed7 🚦 building Environment 8fffed7 status: building 🎪 8fffed7 🚦 deploying Environment 8fffed7 status: deploying 🎪 8fffed7 🚦 running Environment 8fffed7 status: running 🎪 🎯 8fffed7 Active environment pointer - 8fffed7 is receiving traffic labels Sep 9, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 9, 2025

🎪 Showtime deployed environment on GHA for 8fffed7

• Environment: http://54.190.0.29:8080 (admin/admin)
• Lifetime: 24h auto-cleanup
• Updates: New commits create fresh environments automatically

@github-actions GitHub Actions
Copy link
Contributor

🎪 Showtime is building environment on GHA for 16cfd53

@github-actions github-actions bot added 🎪 16cfd53 🚦 deploying Environment 16cfd53 status: deploying 🎪 16cfd53 🚦 running Environment 16cfd53 status: running 🎪 🎯 16cfd53 Active environment pointer - 16cfd53 is receiving traffic 🎪 16cfd53 📅 2025-09-15T18-31 Environment 16cfd53 created at 2025-09-15T18-31 🎪 16cfd53 🌐 44.249.152.151:8080 Environment 16cfd53 URL: http://44.249.152.151:8080 (click to visit) and removed 🎪 16cfd53 🚦 building Environment 16cfd53 status: building 🎪 16cfd53 🚦 deploying Environment 16cfd53 status: deploying 🎪 16cfd53 🚦 running Environment 16cfd53 status: running 🎪 🎯 16cfd53 Active environment pointer - 16cfd53 is receiving traffic 🎪 16cfd53 📅 2025-09-15T18-30 Environment 16cfd53 created at 2025-09-15T18-30 🎪 8fffed7 🤡 mistercrunch Environment 8fffed7 requested by mistercrunch 🎪 8fffed7 📅 2025-09-09T16-20 Environment 8fffed7 created at 2025-09-09T16-20 🎪 8fffed7 🌐 54.190.0.29:8080 Environment 8fffed7 URL: http://54.190.0.29:8080 (click to visit) 🎪 8fffed7 🚦 running Environment 8fffed7 status: running 🎪 8fffed7 ⌛ 24h Environment 8fffed7 expires after 24h labels Sep 15, 2025
@github-actions GitHub Actions
Copy link
Contributor

🎪 Showtime deployed environment on GHA for 16cfd53

• Environment: http://44.249.152.151:8080 (admin/admin)
• Lifetime: 24h auto-cleanup
• Updates: New commits create fresh environments automatically

geido
geido approved these changes Sep 17, 2025
View reviewed changes
Copy link
Member

@geido geido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of nits!

alexandrusoare
alexandrusoare approved these changes Sep 17, 2025
View reviewed changes
Copy link
Contributor

@alexandrusoare alexandrusoare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - with minor things

superset-frontend/packages/superset-ui-chart-controls/src/shared-controls/matrixifyControls.tsx

// Validate dimension is selected when visible
const dimensionValidator = (value: any) => {
if (!value?.dimension) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an option to avoid using any? Or does the value have a multitude of types?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think there is a good way to avoid this one

superset-frontend/packages/superset-ui-chart-controls/src/shared-controls/matrixifyControls.tsx
visibility: ({ controls }) =>
(controls?.matrixify_mode_rows?.value ||
controls?.matrixify_mode_columns?.value) !== undefined,
controls?.matrixify_enable_horizontal_layout?.value === true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
controls?.matrixify_enable_horizontal_layout?.value === true,
controls?.matrixify_enable_horizontal_layout?.value,

@msyavuz msyavuz merged commit ad3eff9 into master Sep 17, 2025
77 of 78 checks passed
@msyavuz msyavuz deleted the improve-matrixify branch September 17, 2025 19:57
@msyavuz msyavuz mentioned this pull request Sep 18, 2025
Merged
9 tasks
@mistercrunch mistercrunch added the v6.0 Label added by the release manager to track PRs to be included in the 6.0 branch label Sep 23, 2025
@sadpandajoe sadpandajoe removed the v6.0 Label added by the release manager to track PRs to be included in the 6.0 branch label Sep 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msyavuz msyavuz msyavuz left review comments

@geido geido geido approved these changes

@sadpandajoe sadpandajoe Awaiting requested review from sadpandajoe sadpandajoe is a code owner

@eschutho eschutho Awaiting requested review from eschutho eschutho is a code owner

@rusackas rusackas Awaiting requested review from rusackas rusackas is a code owner

@betodealmeida betodealmeida Awaiting requested review from betodealmeida betodealmeida is a code owner

+2 more reviewers

@korbit-ai korbit-ai[bot] korbit-ai[bot] left review comments

@alexandrusoare alexandrusoare alexandrusoare approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
change:frontend Requires changing the frontend packages preset-io 🎪 🔒 showtime-blocked size/XL 🎪 16cfd53 🤡 msyavuz Environment 16cfd53 requested by msyavuz 🎪 16cfd53 🚦 running Environment 16cfd53 status: running 🎪 16cfd53 ⌛ 24h Environment 16cfd53 expires after 24h 🎪 16cfd53 🌐 44.249.152.151:8080 Environment 16cfd53 URL: http://44.249.152.151:8080 (click to visit) 🎪 16cfd53 📅 2025-09-15T18-31 Environment 16cfd53 created at 2025-09-15T18-31
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mistercrunch @alexandrusoare @geido @msyavuz @sadpandajoe