fix(deck.gl): restore legend display for Polygon charts with linear palette and fixed color schemes #35142
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Root Cause
The bucket generation logic incorrectly treated any truthy colorSchemeType as requiring color breakpoints:
before:
after:
When colorSchemeType was "linear_palette" or "fixed_color", it incorrectly called getColorBreakpointsBuckets() with undefined color_breakpoints, returning empty buckets and causing legends to disappear.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
11 comprehensive tests covering all scenarios:
Manual test:
ADDITIONAL INFORMATION