Skip to content

Add TO Go deliveryservices/id/health #2458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 9, 2020
Merged

Add TO Go deliveryservices/id/health #2458

merged 1 commit into from
Jan 9, 2020

Conversation

rob05c
Copy link
Member

@rob05c rob05c commented Jun 23, 2018 •
edited by ocket8888
Loading

Branched from #2305 - recommend merging that first. Closes #3787

@rob05c rob05c added new feature A new feature, capability or behavior Traffic Ops API (golang) labels Jun 23, 2018
@rob05c rob05c mentioned this pull request Jun 23, 2018
Closed
@asfgit
Copy link
Contributor

asfgit commented Jun 23, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/1898/
Test PASSed.

@rob05c rob05c force-pushed the to-go-ds-health branch 2 times, most recently from aa9c479 to 54b6062 Compare June 23, 2018 18:50
@asfgit
Copy link
Contributor

asfgit commented Jun 23, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/1899/
Test PASSed.

@rob05c rob05c force-pushed the to-go-ds-health branch from 54b6062 to 5bcba9a Compare July 5, 2018 19:56
@asfgit
Copy link
Contributor

asfgit commented Jul 5, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/1999/
Test PASSed.

@rob05c rob05c force-pushed the to-go-ds-health branch from 5bcba9a to 52e1629 Compare July 9, 2018 19:35
@asfgit
Copy link
Contributor

asfgit commented Jul 9, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/2057/
Test PASSed.

@rob05c rob05c force-pushed the to-go-ds-health branch from 52e1629 to 57b4e48 Compare July 18, 2018 15:11
@asfgit
Copy link
Contributor

asfgit commented Jul 19, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/2115/
Test FAILed.

@ocket8888 ocket8888 mentioned this pull request Aug 6, 2019
Closed
1 task
@rob05c rob05c force-pushed the to-go-ds-health branch 2 times, most recently from 4d8df14 to b6c99b8 Compare September 16, 2019 14:35
@asf-ci
Copy link
Contributor

asf-ci commented Sep 16, 2019

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4258/
Test FAILed.

@asf-ci
Copy link
Contributor

asf-ci commented Sep 16, 2019

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4259/
Test PASSed.

@asf-ci
Copy link
Contributor

asf-ci commented Sep 16, 2019

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4260/
Test PASSed.

mitchell852
mitchell852 requested changes Sep 25, 2019
View reviewed changes
Copy link
Member

@mitchell852 mitchell852 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rob05c - i think this PR needs the changes that were made in #3927

@mitchell852 mitchell852 added Traffic Ops related to Traffic Ops tech debt rework due to choosing easy/limited solution and removed new feature A new feature, capability or behavior labels Oct 24, 2019
@mitchell852 mitchell852 added this to the Go Rewrite milestone Oct 24, 2019
@asf-ci
Copy link
Contributor

asf-ci commented Dec 10, 2019

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4904/

@rob05c rob05c force-pushed the to-go-ds-health branch 2 times, most recently from 1fd1e8c to 1b9d584 Compare December 11, 2019 21:29
@rob05c
Copy link
Member Author

rob05c commented Dec 11, 2019

Rebased with master and #2305, includes #3927 changes.
Manually tested again, still works as expected, still matches Perl.

@rob05c rob05c requested a review from mitchell852 December 11, 2019 21:38
@asf-ci
Copy link
Contributor

asf-ci commented Dec 11, 2019

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4912/

@asf-ci
Copy link
Contributor

asf-ci commented Dec 11, 2019

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4914/

@ocket8888
Copy link
Contributor

Can you rebase this?

@asf-ci
Copy link
Contributor

asf-ci commented Dec 30, 2019

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4978/

@ocket8888 ocket8888 self-assigned this Jan 1, 2020
ocket8888
ocket8888 approved these changes Jan 8, 2020
View reviewed changes
Copy link
Contributor

@ocket8888 ocket8888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, unit and API tests all pass.

@ocket8888 ocket8888 merged commit 71fd364 into apache:master Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ocket8888 ocket8888 ocket8888 approved these changes

@mitchell852 mitchell852 Awaiting requested review from mitchell852

Assignees

@ocket8888 ocket8888

Labels
tech debt rework due to choosing easy/limited solution Traffic Ops related to Traffic Ops
Projects
None yet
Milestone
Go Rewrite
Development

Successfully merging this pull request may close these issues.

Rewrite /deliveryservices/{{id}/health to Go
5 participants
@rob05c @asfgit @asf-ci @ocket8888 @mitchell852