Skip to content

chore: ck ping use wget instead of curl#2230

Merged
loomts merged 1 commit intomainfrom
bugfix/ck-ping
Nov 12, 2025
Merged

chore: ck ping use wget instead of curl#2230
loomts merged 1 commit intomainfrom
bugfix/ck-ping

Conversation

@loomts
Copy link
Copy Markdown
Contributor

@loomts loomts commented Nov 12, 2025

No description provided.

@loomts loomts requested review from a team and leon-inf as code owners November 12, 2025 02:15
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.00%. Comparing base (a1cb35c) to head (8836e03).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #2230   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files         72      72           
  Lines       9480    9480           
=====================================
  Misses      9480    9480           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@shanshanying shanshanying left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better to use CURL with ca info. but for the moment, it is acceptable to use wget with no-cert flag for readiness check.

@loomts
Copy link
Copy Markdown
Contributor Author

loomts commented Nov 12, 2025

better to use CURL with ca info. but for the moment, it is acceptable to use wget with no-cert flag for readiness check.

you are absolutely right, busybox don't contain the curl brinary, If we need to introduce curl, we should use a larger init image, just KISS right now, and we can do the real TLS check in the future :D

@loomts loomts added pick-1.0 Auto cherry-pick to release-1.0 when PR merged chart-release-1.0 Auto release chart when PR merged release-1.0. labels Nov 12, 2025
@loomts loomts merged commit b708239 into main Nov 12, 2025
22 of 23 checks passed
@loomts loomts deleted the bugfix/ck-ping branch November 12, 2025 02:46
@apecloud-bot
Copy link
Copy Markdown
Collaborator

/cherry-pick release-1.0

@apecloud-bot
Copy link
Copy Markdown
Collaborator

🤖 says: cherry pick action finished successfully 🎉!
See: https://github.com/apecloud/kubeblocks-addons/actions/runs/19284693051

apecloud-bot pushed a commit that referenced this pull request Nov 12, 2025
@JashBook
Copy link
Copy Markdown
Collaborator

/cherry-pick release-0.9

@apecloud-bot
Copy link
Copy Markdown
Collaborator

🤖 says: Error cherry-picking.

Auto-merging addons/clickhouse/templates/cmpd-ch.yaml
CONFLICT (content): Merge conflict in addons/clickhouse/templates/cmpd-ch.yaml
Auto-merging addons/clickhouse/values.yaml
error: could not apply b708239... chore: ck ping use wget instead of curl (#2230)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
hint: Disable this message with "git config set advice.mergeConflict false"

@apecloud-bot
Copy link
Copy Markdown
Collaborator

🤖 says: ‼️ cherry pick action failed.
See: https://github.com/apecloud/kubeblocks-addons/actions/runs/19284812033

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chart-release-1.0 Auto release chart when PR merged release-1.0. pick-1.0 Auto cherry-pick to release-1.0 when PR merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants