Skip to content

fix: PVCs being garbage-collected despite retention policy#10043

Merged
leon-ape merged 1 commit intorelease-1.0from
bugfix/retained-pvc-owner-reference
Feb 6, 2026
Merged

fix: PVCs being garbage-collected despite retention policy#10043
leon-ape merged 1 commit intorelease-1.0from
bugfix/retained-pvc-owner-reference

Conversation

@leon-ape
Copy link
Copy Markdown
Contributor

@leon-ape leon-ape commented Feb 6, 2026

cherry picked from commit 7a1c7f6

@leon-ape leon-ape added this to the Release 1.0.2 milestone Feb 6, 2026
@leon-ape leon-ape requested a review from a team as a code owner February 6, 2026 07:33
@apecloud-bot
Copy link
Copy Markdown
Collaborator

Auto Cherry-pick Instructions

Usage:
  - /nopick: Not auto cherry-pick when PR merged.
  - /pick: release-x.x [release-x.x]: Auto cherry-pick to the specified branch when PR merged.

Example:
  - /nopick
  - /pick release-1.1

@github-actions github-actions bot added the size/M Denotes a PR that changes 30-99 lines. label Feb 6, 2026
@leon-ape
Copy link
Copy Markdown
Contributor Author

leon-ape commented Feb 6, 2026

/nopick

@apecloud-bot apecloud-bot added the nopick Not auto cherry-pick when PR merged label Feb 6, 2026
@apecloud-bot apecloud-bot added the approved PR Approved Test label Feb 6, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 6, 2026

Codecov Report

❌ Patch coverage is 10.00000% with 18 lines in your changes missing coverage. Please review.
✅ Project coverage is 53.83%. Comparing base (2df3178) to head (ac2df50).
⚠️ Report is 2 commits behind head on release-1.0.

Files with missing lines Patch % Lines
pkg/controller/instanceset/reconciler_deletion.go 10.00% 18 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           release-1.0   #10043      +/-   ##
===============================================
+ Coverage        53.73%   53.83%   +0.09%     
===============================================
  Files              493      493              
  Lines            54822    54838      +16     
===============================================
+ Hits             29460    29523      +63     
+ Misses           22420    22374      -46     
+ Partials          2942     2941       -1     
Flag Coverage Δ
unittests 53.83% <10.00%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@leon-ape leon-ape merged commit 30c8209 into release-1.0 Feb 6, 2026
48 of 49 checks passed
@leon-ape leon-ape deleted the bugfix/retained-pvc-owner-reference branch February 6, 2026 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved PR Approved Test nopick Not auto cherry-pick when PR merged size/M Denotes a PR that changes 30-99 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Restore Halt TerminationPolicy (or equivalent) — critical gap for datastore workloads

4 participants