Skip to content

chore(deps): update ubuntu docker tag to v24 #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chore(deps): update ubuntu docker tag to v24 #134

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion node-playwright-webkit/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM --platform=linux/amd64 ubuntu:jammy
FROM --platform=linux/amd64 ubuntu:noble

Check warning on line 1 in node-playwright-webkit/Dockerfile

View workflow job for this annotation

GitHub Actions / img: node-playwright-webkit node: 22, apify: ^3.3.0, crawlee: ^3.12.2, pw: 1.50.1, is-latest: true

FROM --platform flag should not use a constant value 

FromPlatformFlagConstDisallowed: FROM --platform flag should not use constant value "linux/amd64"
More info: https://docs.docker.com/go/dockerfile/rule/from-platform-flag-const-disallowed/

Check warning on line 1 in node-playwright-webkit/Dockerfile

View workflow job for this annotation

GitHub Actions / img: node-playwright-webkit node: 20, apify: ^3.3.0, crawlee: ^3.12.2, pw: 1.50.1, is-latest: true

FROM --platform flag should not use a constant value 

FromPlatformFlagConstDisallowed: FROM --platform flag should not use constant value "linux/amd64"
More info: https://docs.docker.com/go/dockerfile/rule/from-platform-flag-const-disallowed/

Check warning on line 1 in node-playwright-webkit/Dockerfile

View workflow job for this annotation

GitHub Actions / img: node-playwright-webkit node: 18, apify: ^3.3.0, crawlee: ^3.12.2, pw: 1.50.1, is-latest: true

FROM --platform flag should not use a constant value 

FromPlatformFlagConstDisallowed: FROM --platform flag should not use constant value "linux/amd64"
More info: https://docs.docker.com/go/dockerfile/rule/from-platform-flag-const-disallowed/
ARG NODE_VERSION=20

LABEL maintainer="[email protected]" description="Base image for Apify Actors using Webkit"
Expand Down Expand Up @@ -78,7 +78,7 @@
ENV APIFY_DEFAULT_BROWSER_PATH=${PLAYWRIGHT_BROWSERS_PATH}/MiniBrowser

# Prevent installing of browsers by future `npm install`.
ENV PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD 1

Check warning on line 81 in node-playwright-webkit/Dockerfile

View workflow job for this annotation

GitHub Actions / img: node-playwright-webkit node: 22, apify: ^3.3.0, crawlee: ^3.12.2, pw: 1.50.1, is-latest: true

Legacy key/value format with whitespace separator should not be used 

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format
More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/

Check warning on line 81 in node-playwright-webkit/Dockerfile

View workflow job for this annotation

GitHub Actions / img: node-playwright-webkit node: 20, apify: ^3.3.0, crawlee: ^3.12.2, pw: 1.50.1, is-latest: true

Legacy key/value format with whitespace separator should not be used 

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format
More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/

Check warning on line 81 in node-playwright-webkit/Dockerfile

View workflow job for this annotation

GitHub Actions / img: node-playwright-webkit node: 18, apify: ^3.3.0, crawlee: ^3.12.2, pw: 1.50.1, is-latest: true

Legacy key/value format with whitespace separator should not be used 

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format
More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/

# We should you the autodisplay detection as suggested here: https://github.com/microsoft/playwright/issues/2728#issuecomment-678083619
ENV DISPLAY=:99
Expand All @@ -90,4 +90,4 @@
# - This needs to be compatible with CLI.
# - Using CMD instead of ENTRYPOINT, to allow manual overriding
# CMD ./start_xvfb_and_run_cmd.sh && npm start --silent
CMD ./new_xvfb_run_cmd.sh npm start --silent

Check warning on line 93 in node-playwright-webkit/Dockerfile

View workflow job for this annotation

GitHub Actions / img: node-playwright-webkit node: 22, apify: ^3.3.0, crawlee: ^3.12.2, pw: 1.50.1, is-latest: true

JSON arguments recommended for ENTRYPOINT/CMD to prevent unintended behavior related to OS signals 

JSONArgsRecommended: JSON arguments recommended for CMD to prevent unintended behavior related to OS signals
More info: https://docs.docker.com/go/dockerfile/rule/json-args-recommended/

Check warning on line 93 in node-playwright-webkit/Dockerfile

View workflow job for this annotation

GitHub Actions / img: node-playwright-webkit node: 20, apify: ^3.3.0, crawlee: ^3.12.2, pw: 1.50.1, is-latest: true

JSON arguments recommended for ENTRYPOINT/CMD to prevent unintended behavior related to OS signals 

JSONArgsRecommended: JSON arguments recommended for CMD to prevent unintended behavior related to OS signals
More info: https://docs.docker.com/go/dockerfile/rule/json-args-recommended/

Check warning on line 93 in node-playwright-webkit/Dockerfile

View workflow job for this annotation

GitHub Actions / img: node-playwright-webkit node: 18, apify: ^3.3.0, crawlee: ^3.12.2, pw: 1.50.1, is-latest: true

JSON arguments recommended for ENTRYPOINT/CMD to prevent unintended behavior related to OS signals 

JSONArgsRecommended: JSON arguments recommended for CMD to prevent unintended behavior related to OS signals
More info: https://docs.docker.com/go/dockerfile/rule/json-args-recommended/
Loading