feat: Add error data to ApifyApiError #314
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add tests.
Pijukatel
added
enhancement
github-actions
bot
added
the
tested
Pijukatel
changed the title
janbuchar
reviewed
Dec 13, 2024
tests/unit/test_client_errors.py
Outdated
|
|
||
|
|
||
| @respx.mock | ||
| @pytest.fixture |
There was a problem hiding this comment.
Is this autoused somehow?
There was a problem hiding this comment.
It is used by
@pytest.mark.usefixtures('mocked_response')
I would normally just pass the fixture into the args, but then ruff is complaining about unused args :-(, so I thought this somewhat less common way of using fixtures is better than #ignore comment.
There was a problem hiding this comment.
I would prefer either fixture(autouse=True) or disabling that rule for tests
janbuchar
approved these changes
Dec 16, 2024
vdusek
reviewed
Dec 16, 2024
Pijukatel
added a commit
to apify/apify-docs
that referenced
this pull request
Dec 16, 2024
#1356) Add Python variant example of catching dataset validation errors. Documents this change: apify/apify-client-python#314
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add error data to ApifyApiError when available.
Add tests.
Closes: #306