Dead/broken code in apigee_edge_user_presave()

[mxr576]

Description

PHPStorm warns that the following code is incorrect, because $user_developer->convertUser() returns \Drupal\apigee_edge\Structure\UserToDeveloperConversionResult() and not a developer interface.

            $developer = $user_developer->convertUser($account);
            $developer->setDeveloperId($developer_id);
            $developer->enforceIsNew(FALSE);

It also occurred to me if this code is dead or how this potentially fatal error has not been recognized so far.

Apigee Info

N/A

Steps to Reproduce

N/A

Actual Behavior

N/A

Expected Behavior

N/A

Screenshots

N/A

Notes

N/A

Version Info

4.0.2

[mxr576]

Also, how it could happen that static code analyzers did not spot this already?

[mxr576]

Identified when i worked on #1153

[kedarkhaire]

Thank you @mxr576 for identifying the issue. We will look into it, meanwhile if you have a working resolution for it, please do share.