This repository was archived by the owner on Sep 4, 2024. It is now read-only.
Merged
Conversation
Merged
Owner
|
Kicked CI. We're getting linker failures in |
Clear all the clippy warnings introduce by a recent clippy update.
tcharding
force-pushed
the
11-17-clippy
branch
from
acca8ba to
4fd4cb1
Compare
Collaborator
Author
|
Rebased on #75, seems to work. |
Merged
casey
reviewed
Nov 17, 2022
| @@ -27,7 +28,7 @@ jobs: | |||
| - name: Running tests on ${{ matrix.toolchain }} | |||
Contributor
There was a problem hiding this comment.
You can do this to avoid running on macos:
if: ${{ matrix.os != 'macOS-latest' }}
Also, I've seen it spelled macos-latest before, but maybe that doesn't matter.
Owner
There was a problem hiding this comment.
How do I prevent specifically rustc 1.41 from running on macos?
Contributor
There was a problem hiding this comment.
Ah, sorry, I didn't realize that the combination of macos and 1.41. I didn't test this, but it should be something like:
if: ${{ !(matrix.os == 'macOS-latest' && matrix.toolchain == `1.4.1`) }}
Owner
There was a problem hiding this comment.
It's a huge PITA to test github actions :) bash is easier.
apoelstra
approved these changes
Nov 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clear all the clippy warnings introduce by a recent clippy update.